Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workaround for egui issue with panels #76

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

Plonq
Copy link
Owner

@Plonq Plonq commented May 17, 2024

Implements an optional and imperfect workaround for #75

To use the workaround:

// Insert this resource
.insert_resource(EguiFocusIncludesHover(true))
// Before this plugin
.add_plugins(PanOrbitCameraPlugin)

The reason it is imperfect is that moving the mouse over any egui panel will block all input from panorbit camera, even if you are already dragging (e.g. to rotate).

I've also moved the panorbit systems into PostUpdate to avoid potential race conditions depending on how systems are scheduled.

@Plonq Plonq merged commit 11b0348 into master May 17, 2024
5 checks passed
@Plonq Plonq deleted the egui-workaround branch May 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant