Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy 0.15 #87

Closed
wants to merge 4 commits into from
Closed

Update to bevy 0.15 #87

wants to merge 4 commits into from

Conversation

dmlukichev
Copy link
Contributor

Updated library code, examples and documentation to work with bevy 0.15-rc.3

@Plonq
Copy link
Owner

Plonq commented Nov 13, 2024

Hey, thanks for this, looks like significant changes which saves me time 😄

I won't merge until Bevy 15 is fully released, but this is a good head start.
EDIT: Also need to wait for bevy_egui to update.

Copy link
Owner

@Plonq Plonq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failed checks

.gitignore Outdated Show resolved Hide resolved
@Plonq Plonq marked this pull request as draft November 13, 2024 08:33
@dmlukichev
Copy link
Contributor Author

Formatting fixed, gitignore changes reverted.
I was hoping that you will publish rc version also, but it's up to you to decide.
Thank you for your lib!

@Plonq
Copy link
Owner

Plonq commented Nov 14, 2024

I was hoping that you will publish rc version also, but it's up to you to decide.

I hadn't thought of that, but the egui feature is broken until bevy_egui is updated, so I don't think it's appropriate to release it as RC. Unless bevy_egui puts out an RC version It'll have to wait.

@Plonq
Copy link
Owner

Plonq commented Nov 30, 2024

Waiting for vladbat00/bevy_egui#309

@pta2002
Copy link

pta2002 commented Nov 30, 2024

@Plonq that PR is merged and bevy_egui 0.31 is now released with official support for bevy 0.15. Does that mean that this is ready to get merged?

@Plonq
Copy link
Owner

Plonq commented Dec 1, 2024

@dmlukichev Can you do the following please:

  • Update deps (bevy to 0.15 and bevy_egui)
  • Revert the version and changelog updates (I prefer to do them separately)

@dmlukichev
Copy link
Contributor Author

Hi, @Plonq. Done.

@dmlukichev dmlukichev marked this pull request as ready for review December 2, 2024 17:34
@Plonq
Copy link
Owner

Plonq commented Dec 3, 2024

For some reason I am unable to push changes to this PR. You need to add bevy_window feature to the prod bevy dependency to fix the build.

@mineichen
Copy link
Contributor

Instead of adding Camera3d() to every location, PanOrbitCamera is added, you could add Camera3D as a "required component" and remove Camera3d::default() from the examples.

In Plugin::build

app.register_required_components::<PanOrbitCamera, Camera3d>()

@dmlukichev
Copy link
Contributor Author

Guys, sorry. Not in a position to argue.
It looks like like @mineichen tracks bevy's changes better that I do. I hope he will update this MR accordingly.
Best of luck, Dima

@Plonq
Copy link
Owner

Plonq commented Dec 5, 2024

@dmlukichev Don't worry about that, let's just get this PR fixed and merged.

@mineichen It's a good idea, feel free to open a new PR, or I will later

@Plonq Plonq mentioned this pull request Dec 7, 2024
@Plonq
Copy link
Owner

Plonq commented Dec 7, 2024

I made the necessary changes in #90, so I'll close this one.

@Plonq Plonq closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants