Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trimage builder specifies wrong attributes for altering image center #99

Closed
RussBerg opened this issue May 1, 2023 · 1 comment · Fixed by #101
Closed

trimage builder specifies wrong attributes for altering image center #99

RussBerg opened this issue May 1, 2023 · 1 comment · Fixed by #101
Assignees
Labels

Comments

@RussBerg
Copy link
Collaborator

RussBerg commented May 1, 2023

the lines
https://github.com/PierreRaybaut/guiqwt/blob/83bb8bc3ea67f5e8a2e3a54c142fe8597380dc50/guiqwt/builder.py#L1015-L1016

mistakenly try to set x0 and y0 of the trimage parameter except the attributes are actually pos_x0 and pos_y0, so the lines should be

pos_x0=x0

pos_y0=y0

otherwise the actual center of the trimage parameter (and therefore the image in the plot) will not be set if user specifies x0 and y0 values and instead use the default of both set to 0.0

I will submit a PR shortly

@RussBerg
Copy link
Collaborator Author

RussBerg commented May 1, 2023

or would if I was added as a collaborator :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants