Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of implementation characteristics/tags #195

Merged
merged 16 commits into from
Jun 3, 2021

Conversation

rbergen
Copy link
Contributor

@rbergen rbergen commented May 22, 2021

This PR is drafted to initiate the introduction of defined implementation characteristics. The following is used as a premise:

I'm opening this PR as a draft, for now. The reason is that I think we should first be fully aligned on the contents of the contribution guidelines related to the specification of characteristics, before we start making changes to existing solutions to make them conform to the new setup.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@rbergen
Copy link
Contributor Author

rbergen commented May 30, 2021

I've continued adding labels to existing solutions, and just pushed the changes up to and including PrimeJulia. I implemented but stashed the changes for PrimeCSharp/solution_1, as a proper addition of the labels to that solution requires a different set of changes than just a literal text change to (the) drag-race output line(s). I'll compose a separate PR for that solution (after this PR is merged), that I would like to then receive a review on from @Kinematics, if possible.

I'll keep working down the list of solutions over the next few days, and push again once I've reached the end of the list.

@rbergen
Copy link
Contributor Author

rbergen commented May 30, 2021

All solutions except for one or two exceptions have now had the labels applied. I'm thus marking this PR ready for review. Obviously, we shouldn't merge until the benchmark implementation is updated to process the new output.

@rbergen rbergen marked this pull request as ready for review May 30, 2021 13:18
@rbergen rbergen requested a review from marghidanu May 30, 2021 17:29
@rbergen rbergen changed the title Introduction of implementation characteristics/labels Introduction of implementation characteristics/tags Jun 1, 2021
@mike-barber
Copy link
Contributor

Wow, nice work!

@rbergen
Copy link
Contributor Author

rbergen commented Jun 3, 2021

Wow, nice work!

Thank you! I'm sharing the credits with @marghidanu and @rhbvkleef, because it really took a coordinated effort to make the whole thing work, in the end. :)

@rbergen
Copy link
Contributor Author

rbergen commented Jun 3, 2021

Going to merge this now that I've confirmed that the new benchmark tool report includes tags for all solutions except PrimeCSharp/solution_1, for which I will open a separate PR.

@rbergen rbergen merged commit b31bfaa into PlummersSoftwareLLC:drag-race Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants