-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX updated Atracsys cmake to align with SDK changes #93
Conversation
Can you add back the PLTools path hints to FindAtracsysSDK? It is used by our build machines to compile Plus without installing SDKs. |
4045300
to
8ad50d2
Compare
I added back the PLTools path hints. |
I don't think the path hints are being used anymore. Can you update FindAtracsysSDK.cmake so that it will check for the SDK in PLTools? |
I'm a bit confused, in my last commit I added the path hints as you requested so that PLTools would find the SDK. I'm not sure what else I should do to facilitate the SDK check in PLTools (platform which I don't have any knowledge of). |
In the previous version, the SDK was searched for using the path hints, to find the location of "include/ftkTypes.h":
The desired behavior is that if we have a PLTools folder, we should check there first to set ATRACSYS_DIR, before looking for the installed SDK. Probably this can be done by adding
PLTools is just a version-controlled folder containing SDKs for all of the different devices that we use. I can adjust the directories to search for the SDK in PLTools, so don't worry about the exact path. |
- Changed variables names to avoid warning during config - Moved path_hints to prioritize PLtools
Ok, it should finally work (it does on my machine). The PLtools path hints are set before checking for the installed SDK. Also, I changed the name of the cmake Atracsys variables to avoid a Warning during cmake configuration. There is a PlusLib PR related to the current PR, which should get merged simultaneously. |
Atracsys has changed its SDK inclusion via CMake. The following PR reflects these changes.
I have also changed some of the comments to be more inclusive to the fusionTrack.