Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors when using embedded transforms in vtkPlusOpenIGTLinkVideoSource #873

Open
3 tasks
Sunderlandkyl opened this issue Dec 9, 2021 · 0 comments
Open
3 tasks

Errors when using embedded transforms in vtkPlusOpenIGTLinkVideoSource #873

Sunderlandkyl opened this issue Dec 9, 2021 · 0 comments
Assignees
@Sunderlandkyl

Comments

@Sunderlandkyl
Copy link
Contributor

  • If the From and To coordinate frames of the embedded transform are the same, the Transform repository will log an error ("Setting a transform to itself is not allowed") when sending any images using vtkPlusOpenIGTLinkServer.
  • If an incoming image message has no status set for the embedded transform, the transform is considered invalid.
  • When connecting to another PlusServer, no data will be received by vtkPlusOpenIGTLinkVideoSource if ImageMessageEmbeddedTransformName is not specified.

See discussion here: #871
@Sunderlandkyl Sunderlandkyl self-assigned this Dec 9, 2021
Sunderlandkyl added a commit to Sunderlandkyl/PlusLib that referenced this issue Dec 9, 2021
@Sunderlandkyl
BUG: Fix embedded transform errors in vtkPlusOpenIGTLinkVideoSource
c07ec27 
When receiving messages with embedded transforms from vtkPlusOpenIGTLinkVideoSource, several errors occurred.
- If the From and To coordinate frames of the embedded transform are the same, the Transform repository will log an error ("Setting a transform to itself is not allowed") when sending any images using vtkPlusOpenIGTLinkServer. Fixed by not unpacking the transform when From == To.
- If an incoming image message has no status set for the embedded transform, the transform is considered invalid. Fixed by marking incoming embedded transforms with no status as OK.

Re PlusToolkit#873
@Sunderlandkyl Sunderlandkyl mentioned this issue Dec 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sunderlandkyl Sunderlandkyl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sunderlandkyl