Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/api_post_synthese #1793

Closed
wants to merge 1 commit into from
Closed

feat/api_post_synthese #1793

wants to merge 1 commit into from

Conversation

joelclems
Copy link
Contributor

Route d'échanges pour la synthese

par exemple pour qu'une application externe puisse ecrire dans la syntheèse

@joelclems
Copy link
Contributor Author

TODO

  • doc
  • check geométrie
    • test

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #1793 (e2ed025) into develop (0925f12) will increase coverage by 1.07%.
The diff coverage is 91.28%.

@@             Coverage Diff             @@
##           develop    #1793      +/-   ##
===========================================
+ Coverage    54.22%   55.30%   +1.07%     
===========================================
  Files           76       79       +3     
  Lines         7317     7535     +218     
===========================================
+ Hits          3968     4167     +199     
- Misses        3349     3368      +19     
Flag Coverage Δ
pytest 55.30% <91.28%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/geonature/app.py 82.88% <ø> (ø)
...end/geonature/core/gn_synthese/exchanges/routes.py 83.51% <83.51%> (ø)
...geonature/core/gn_synthese/exchanges/repository.py 96.15% <96.15%> (ø)
...ckend/geonature/core/gn_synthese/exchanges/util.py 97.33% <97.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0925f12...e2ed025. Read the comment docs.

@camillemonchicourt
Copy link
Member

Je comprends pas bien le terme "exchange" retenu. Ça me semble un peu vouloir tout et rien dire "échange", pas très explicite selon moi.

@joelclems
Copy link
Contributor Author

Comme échange entre une appli externe et geonature, au niveua des données de la synthese, on peut tout à fait changer le nom si on trouve mieux

@camillemonchicourt
Copy link
Member

Y a pas un terme plus précis et plus standard ?
Plus REST ?
Ça me semble trop flou et large de parler d'"échange avec la synthèse". C'est pas plutôt simplement "POST dans la synthèse" ?

@joelclems
Copy link
Contributor Author

rest c'est pas mal vu qu'on a les routes get, patch, post et delete

@bouttier bouttier force-pushed the develop branch 2 times, most recently from 79d05d2 to 7a63991 Compare March 30, 2022 09:34
Base automatically changed from develop to master November 8, 2022 16:09
@joelclems joelclems closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants