Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPORT] Extending jdd checks by verifying its active status #3221

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[IMPORT] Extending jdd checks by verifying its active status #3221

merged 2 commits into from
Oct 11, 2024

Conversation

jacquesfize
Copy link
Contributor

No description provided.

@jacquesfize jacquesfize mentioned this pull request Oct 9, 2024
Open
46 tasks
bouttier
bouttier approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@bouttier bouttier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outre les petits corrections, OK pour moi !

backend/geonature/tests/imports/files/occhab/valid_file.csv Outdated Show resolved Hide resolved
backend/geonature/tests/imports/test_imports_occhab.py Outdated Show resolved Hide resolved
@jacquesfize
fix(test) : apply @bouttier renaming suggestion and fix permission fa…
d58e7e3 
…iling test caused by the addition of a new dataset in the fixture
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (523f48d) to head (d58e7e3).
Report is 2 commits behind head on feat/import.

Additional details and impacted files 
@@             Coverage Diff              @@
##           feat/import    #3221   +/-   ##
============================================
  Coverage        83.51%   83.52%           
============================================
  Files              121      121           
  Lines             9543     9548    +5     
============================================
+ Hits              7970     7975    +5     
  Misses            1573     1573
Flag Coverage Δ
pytest 83.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacquesfize jacquesfize merged commit 0a459e9 into feat/import Oct 11, 2024
9 checks passed
@jacquesfize jacquesfize deleted the import-only-jdd-active branch October 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouttier bouttier bouttier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesfize @bouttier