Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiche taxon] Ajout d'option sur la synthèse géographique #3225

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jules-jean-louis1
Copy link

closes https://github.com/orgs/PnX-SI/projects/20/views/7?pane=issue&itemId=69854886

Ajout d'une option de maillage sur la synthèse géographique.
Capture d’écran du 2024-10-11 15-13-50

Le développement réalisé s'appuie sur le composant synthese-carte.

areasEnable: boolean;
areasLegend: any;
private areasLabelSwitchBtn;
public featureGroup: any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est public par défault !

@@ -16,29 +28,208 @@ import { TaxonSheetService } from '../taxon-sheet.service';
})
export class TabGeographicOverviewComponent implements OnInit {
observations: FeatureCollection | null = null;
areasEnable: boolean;
areasLegend: any;
private areasLabelSwitchBtn;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

par convention, on préfixe les champs privés par un "_"

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (0a6c1de) to head (34195ba).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3225      +/-   ##
===========================================
- Coverage    81.94%   81.93%   -0.01%     
===========================================
  Files           86       86              
  Lines         6962     6960       -2     
===========================================
- Hits          5705     5703       -2     
  Misses        1257     1257              
Flag Coverage Δ
pytest 81.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants