Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : first round of tests #141

Merged
merged 4 commits into from
May 11, 2023
Merged

Fix : first round of tests #141

merged 4 commits into from
May 11, 2023

Conversation

JulienCorny
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.09 🎉

Comparison is base (2d04753) 39.32% compared to head (519dda5) 43.42%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           workshop     #141      +/-   ##
============================================
+ Coverage     39.32%   43.42%   +4.09%     
============================================
  Files            10       10              
  Lines           656      654       -2     
============================================
+ Hits            258      284      +26     
+ Misses          398      370      -28
Flag Coverage Δ
pytest 43.42% <100.00%> (+4.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/gn_module_export/blueprint.py 55.39% <100.00%> (+9.27%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpm-cbna jpm-cbna changed the title first round of tests First round of tests May 11, 2023
@jpm-cbna jpm-cbna added the enhancement New feature or request label May 11, 2023
@jpm-cbna jpm-cbna self-assigned this May 11, 2023
jpm-cbna
jpm-cbna approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@jpm-cbna jpm-cbna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cela me semble ok.
Les tests passent en local sur ma machine.

bouttier
bouttier requested changes May 11, 2023
View reviewed changes
backend/gn_module_export/tests/test_blueprint.py Outdated Show resolved Hide resolved
backend/gn_module_export/tests/test_blueprint.py Outdated Show resolved Hide resolved
backend/gn_module_export/tests/test_blueprint.py Outdated
url_for("exports.get_one_export_api", id_export=1000000)
)
assert response.status_code == 200
assert response.json == []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert response.json == []

backend/gn_module_export/blueprint.py Outdated Show resolved Hide resolved
backend/gn_module_export/blueprint.py Outdated Show resolved Hide resolved
backend/gn_module_export/blueprint.py Outdated Show resolved Hide resolved
@jpm-cbna jpm-cbna changed the title First round of tests Feat : first round of tests May 11, 2023
@jpm-cbna jpm-cbna changed the title Feat : first round of tests Fix : first round of tests May 11, 2023
@bouttier bouttier merged commit ffbab93 into PnX-SI:workshop May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouttier bouttier bouttier requested changes

@jpm-cbna jpm-cbna jpm-cbna approved these changes

Assignees

@jpm-cbna jpm-cbna

Labels
enhancement New feature or request
Projects
Refonte module EXPORT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulienCorny @bouttier @jpm-cbna