Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove global var from function args list #3

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Conversation

Doozers
Copy link
Contributor

@Doozers Doozers commented Jun 5, 2022

Description

Fix misunderstanding in codebase.

Changes include

  • [X ] Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • [ X] I have assigned this PR to myself
  • [X ] I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@Doozers Doozers requested a review from OnsagerHe June 5, 2022 13:33
@Doozers Doozers self-assigned this Jun 5, 2022
@Doozers Doozers added the enhancement New feature or request label Jun 5, 2022
@Doozers Doozers merged commit b6a38fa into main Jun 5, 2022
@Doozers Doozers deleted the fix/parseNewPosts branch June 5, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant