Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Voting system workshop #102

Merged
merged 7 commits into from
Sep 28, 2024
Merged

Create Voting system workshop #102

merged 7 commits into from
Sep 28, 2024

Conversation

Sacharbon
Copy link
Collaborator

Description

Add the new voting system workshop

Changes include

add README, setup, util & dApp folder.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have added sufficient documentation in the code

@Sacharbon Sacharbon self-assigned this Sep 5, 2024

### 📌 **Tasks**:

Remove the files from `script/`, `src/` and `test` directories. Create `VotingSystem.sol` in the `src/` folder.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explique plus. Dit qu'il faut créer un contrat nommer VotingSystem et qu'il faut mettre le header du fichier

// SPDX-License-Identifier: UNLICENSED  
pragma solidity ^0.8.26;

- Create a structure named `Proposal`
>💡 The structure should have 2 variables, `name` and `voteCount`. I let you guess their types.

- On deployment, the contract should take an array of strings as parameters and store them in a `public` array of `Proposals`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explique que c'est un constructeur ce qu'il doivent faire et qu'il prend en param un array de string (c'est moins ambigu)

Comment on lines 66 to 67
- Using Anvil and forge, deploy your smart contract on a local testnet.
- Paste the address of your deployed contract into the environment file at the root of the dApp folder named `VITE_ADDRESS`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explique qu'il faut démarrer anvil et après deployer le contrat. l'address du contrat deployer apparait sous le nom deployed to


### 📌 **Tasks**:

- Create a structure `Voter`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precise ce que dois contenir la structure (on peux pas le deviner) et du coup sa permet de comprendre a quoi correspond l'id que tu demande en dessous

Comment on lines +86 to +92
h1 {
font-size: 3rem;
font-weight: bold;
}
h2 {
font-size: 1.8rem;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fait gaffe a la couleur du text. pour moi la couleur des nom des proposals sont noir sur un fond gris donc on voit rien

@Sacharbon Sacharbon merged commit 3a29e93 into master Sep 28, 2024
2 checks passed
@Sacharbon Sacharbon deleted the voting-system branch September 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants