Implements Issue #228 - Comments: Load optimization #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, the comments are pushed to the UI via a chunked HTTP request, as soon as their replies are loaded. There is further room for optimization by sending the comments and replies in different steps.
|
39fa9ea removes some left over logs I used for debugging. I recommend merging with "Squash and merge". |
ericpp
reviewed
Feb 27, 2023
ericpp
reviewed
Feb 27, 2023
|
@ericpp thanks a lot for the review! |
Removed leftover debug logs. Co-authored-by: Eric P <ericpp@users.noreply.github.com>
Removed leftover debug logs. Co-authored-by: Eric P <ericpp@users.noreply.github.com>
|
Will push this to production tomorrow! |
|
That's great! |
dellagustin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the comments are pushed to the UI via a chunked HTTP request, as soon as their replies are loaded. There is further room for optimization by sending the comments and replies in different steps.
Related issues: