Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the format matches but unmanglePath yields a falsey string, there is no way to know what happened. #30

Open
1 task done
Poikilos opened this issue Sep 16, 2023 · 0 comments
Open
1 task done

If the format matches but unmanglePath yields a falsey string, there is no way to know what happened. #30

Poikilos opened this issue Sep 16, 2023 · 0 comments

Comments

@Poikilos
Copy link
Owner

Poikilos commented Sep 16, 2023 •
edited
Loading

Either

  1. parser doesn't match at all, or
  2. the path is malformed (unmanglePath didn't work--either it is deficient or base path detection was faulty so a similar fuzzy-matched file that exists wasn't found)

..but only the 2nd case is a NotImplementedError type of issue and there is no way to tell whether 1 or 2 is the case...

  • (was already done) unless it ends with .lua, in which case an exception is already raised
Poikilos added a commit that referenced this issue Sep 16, 2023
@Poikilos
Instead of crashing if cited non-.lua path not found, show a warning …
0227ed8 
…and try the next parser (mitigate issue #30).
Poikilos added a commit that referenced this issue Sep 16, 2023
@Poikilos
Instead of crashing if cited non-.lua path not found, show verbose in…
0bf7655 
…fo and try the next parser (mitigate issue #30).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Poikilos