Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build sdist with build to ensure proper readme contents and format #107

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Build sdist with build to ensure proper readme contents and format #107

merged 1 commit into from
Feb 20, 2024

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine added tag: internal Issues and PRs for maintainance of the project - not interesting to external users part: build Issues and PRs related to the build process labels Feb 20, 2024
@timkpaine timkpaine mentioned this pull request Feb 20, 2024
Closed
@timkpaine timkpaine marked this pull request as draft February 20, 2024 20:39
ngoldbaum
ngoldbaum previously approved these changes Feb 20, 2024
View reviewed changes
@ngoldbaum
Copy link
Collaborator

Ah, good call. No wonder if was picking up metadata from setup.py.

@timkpaine
Copy link
Member Author

This works locally but not in CI 😢

@timkpaine
Build sdist with build to ensure proper readme contents and format
9ee3d33 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine
Copy link
Member Author

This works locally but not in CI 😢

Ok updating setuptools dependency did the trick

@timkpaine timkpaine marked this pull request as ready for review February 20, 2024 20:56
@ngoldbaum ngoldbaum merged commit 08da9a8 into main Feb 20, 2024
14 checks passed
@ngoldbaum ngoldbaum deleted the tkp/sdist branch February 20, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
part: build Issues and PRs related to the build process tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @ngoldbaum