Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket client adapter #152

Merged
merged 1 commit into from
Apr 5, 2024
Merged

websocket client adapter #152

merged 1 commit into from
Apr 5, 2024

Conversation

wrieg123
Copy link
Collaborator

Added a Websocket Client Adapter (w/ and w/o TLS support).

Further, there is an output adapter for updating headers on reconnects.

@wrieg123 wrieg123 requested a review from robambalu March 14, 2024 14:21
@wrieg123 wrieg123 force-pushed the wrr/websockets branch 2 times, most recently from 7f9f923 to 91bc70b Compare March 14, 2024 15:35
@timkpaine timkpaine added adapter: new Issues and PRs related to creating new input/output adapters type: feature Issues and PRs related to new features labels Mar 17, 2024
AdamGlustein
AdamGlustein previously requested changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@AdamGlustein AdamGlustein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first pass through just focusing on the csp related code as I'm not familiar with how websockets work.

conda/dev-environment-linux.yml Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientInputAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientInputAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientInputAdapter.cpp Outdated Show resolved Hide resolved
csp/adapters/websocket_client.py Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/WebsocketEndpoint.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientOutputAdapter.h Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientOutputAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientHeaderUpdateAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientAdapterManager.h Outdated Show resolved Hide resolved
timkpaine
timkpaine previously requested changes Mar 22, 2024
View reviewed changes
conda/dev-environment-linux.yml Outdated Show resolved Hide resolved
@wrieg123 wrieg123 force-pushed the wrr/websockets branch 5 times, most recently from 1883fa9 to 1566b5f Compare March 22, 2024 02:54
timkpaine
timkpaine requested changes Mar 22, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@wrieg123 wrieg123 requested a review from timkpaine March 22, 2024 21:09
timkpaine
timkpaine previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comfortable with the vcpkg, cmake, conda, and setup.py changes. The remaining will require other people to review

@wrieg123 wrieg123 force-pushed the wrr/websockets branch 2 times, most recently from 663151f to e59c5ff Compare March 22, 2024 21:59
robambalu
robambalu reviewed Mar 25, 2024
View reviewed changes
cpp/csp/adapters/websockets/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientAdapterManager.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/WebsocketEndpoint.h Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/WebsocketEndpoint.h Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/WebsocketEndpoint.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientHeaderUpdateAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientHeaderUpdateAdapter.cpp Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientHeaderUpdateAdapter.h Outdated Show resolved Hide resolved
cpp/csp/adapters/websockets/ClientOutputAdapter.h Outdated Show resolved Hide resolved
cpp/csp/python/adapters/websocketsadapterimpl.cpp Outdated Show resolved Hide resolved
@wrieg123 wrieg123 force-pushed the wrr/websockets branch 5 times, most recently from 6fb4924 to e13f08c Compare April 2, 2024 14:06
timkpaine
timkpaine previously requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot the NOTICE also has to be regenerated

@wrieg123 wrieg123 requested a review from timkpaine April 2, 2024 16:31
@wrieg123
websocket client adapter
f0aa29d 
Signed-off-by: Rieger <wr10136@devqtccrt05.saccap.int>
@robambalu robambalu self-requested a review April 5, 2024 17:53
@wrieg123 wrieg123 merged commit 0eb84fc into main Apr 5, 2024
22 checks passed
@wrieg123 wrieg123 deleted the wrr/websockets branch April 5, 2024 17:57
timkpaine
timkpaine reviewed Apr 5, 2024
View reviewed changes
conda/dev-environment-unix.yml
@@ -18,6 +18,7 @@ dependencies:
- isort
- libarrow=15
- librdkafka
- libboost-headers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrieg123 alphabetize!

@timkpaine timkpaine mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine left review comments

@robambalu robambalu robambalu approved these changes

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@czgdp1807 czgdp1807 Awaiting requested review from czgdp1807

@AdamGlustein AdamGlustein Awaiting requested review from AdamGlustein AdamGlustein is a code owner

Assignees
No one assigned
Labels
adapter: new Issues and PRs related to creating new input/output adapters type: feature Issues and PRs related to new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wrieg123 @timkpaine @robambalu @AdamGlustein