minor bugfix to unroll cppimpl #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mT, which for bool would be a vector value of unsigned char. This was triggering a CSP_ASSERT in debug builds Signed-off-by: Rob Ambalu <robert.ambalu@point72.com>
robambalu
requested review from
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
svatasoiu
approved these changes
May 6, 2024
timkpaine
changed the title
timkpaine
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing cast from vector value to
ElemT, which for bool would be a vector value of unsigned char. This was triggering a CSP_ASSERT in debug builds