Optimize csp.stats calculations for expanding intervals #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
robambalu,
svatasoiu and
alexddobkin
as code owners
AdamGlustein
force-pushed
the
efficient-expanding-window-calculations
branch
from
97c599e
to
cf83bec
Compare
…aintain a costly VariableSizedWindowBuffer Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
AdamGlustein
force-pushed
the
efficient-expanding-window-calculations
branch
from
cf83bec
to
1b0f17c
Compare
timkpaine
added
the
type: enhancement
robambalu
reviewed
May 23, 2024
robambalu
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by @svatasoiu there is no need to maintain a costly VariableSizedWindowBuffer for expanding windows. It is unnecessary logic and also grows unbounded.
All we need to do is store yet-to-be-released additions in a vector and swap it with the last value when we tick them out (similar approach to how we handle removals for a tick-count specified buffer). This approach a) avoids memory allocation and b) keeps all the sampling logic in the window update nodes.