Implement pickling for PyStructList and FastList #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogarokpeter
requested review from
robambalu,
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
ogarokpeter
requested review from
ptomecek,
timkpaine and
czgdp1807
as code owners
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
robambalu
requested changes
Jun 18, 2024
Signed-off-by: Petr Ogarok <petr.ogarok@point72.com>
robambalu
approved these changes
Jun 18, 2024
wrieg123
pushed a commit
to wrieg123/csp
that referenced
this pull request
Jul 16, 2024
* Attempt to pinpoint PicklingError: unable to import _cspimpl Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Remove note about gnu toolchain from docs Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * fix listing/linting typo Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * add markdown linters to wiki Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Force numpy<2 for now Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Implement pickling for PyStructList and FastList Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Clean up code changes for pickling impl Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Fix linting Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Remove Py_NewRef as not available in PY3.8 Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> * Address code review comments Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> --------- Signed-off-by: Petr Ogarok <petr.ogarok@point72.com> Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com> Co-authored-by: Tim Paine <timothy.paine@cubistsystematic.com>
timkpaine
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273