Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up earthquake data push-pull adapter example #345

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Fix up earthquake data push-pull adapter example #345

merged 6 commits into from
Jul 18, 2024

Conversation

AdamGlustein
Copy link
Collaborator

Fixes up #304

Definitely our coolest example yet!

earthquake_example

@melissawm
Add PushPullAdapter example with earthquake data
f51aaef 
Signed-off-by: Melissa Weber Mendonça <melissawm@gmail.com>
@melissawm
Rework PushPull logic
a65c1b6 
Signed-off-by: Melissa Weber Mendonça <melissawm@gmail.com>
@melissawm
Add earthquake example to README
6b3c2ca 
Signed-off-by: Melissa Weber Mendonça <melissawm@gmail.com>
@melissawm
Revert changes to dev-environment-unix.yml
eb1302c 
Signed-off-by: Melissa Weber Mendonça <melissawm@gmail.com>
@melissawm
Lint end-to-end examples README
f6e3c42 
Signed-off-by: Melissa Weber Mendonça <melissawm@gmail.com>
@AdamGlustein
Fix up example and incorporate PR comments
44dbb7c 
Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
@AdamGlustein AdamGlustein added the part: examples Issues and PRs related to examples label Jul 18, 2024
@AdamGlustein AdamGlustein mentioned this pull request Jul 18, 2024
Merged
timkpaine
timkpaine approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AdamGlustein AdamGlustein merged commit 65207a4 into main Jul 18, 2024
29 checks passed
@AdamGlustein AdamGlustein deleted the earthquake-example branch July 18, 2024 20:25
@AdamGlustein AdamGlustein mentioned this pull request Jul 19, 2024
Closed
wrieg123 pushed a commit to wrieg123/csp that referenced this pull request Jul 20, 2024
@AdamGlustein @melissawm @wrieg123
Fix up earthquake data push-pull adapter example (Point72#345)
d167557 
Add PushPullAdapter example with earthquake data

---------

Signed-off-by: Melissa Weber Mendonça <melissawm@gmail.com>
Signed-off-by: Adam Glustein <Adam.Glustein@Point72.com>
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine approved these changes

@ptomecek ptomecek Awaiting requested review from ptomecek

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
part: examples Issues and PRs related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamGlustein @timkpaine @melissawm