Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sqlalchemy>=2 #6

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Support sqlalchemy>=2 #6

merged 2 commits into from
Feb 7, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Feb 2, 2024 •
edited
Loading

This PR adds support for sqlalchemy>=2 for the DBReader adapter.

  • Fix lint / remove debugging and prints
  • Add CI/CD for testing test_db.py for SQLAlchemy >2 and <2
  • Restore behavior necessary to facilitate bullet 2
  • update dev-dependencies.yml conda env

@timkpaine timkpaine force-pushed the tkp/sqla2 branch 3 times, most recently from a03fff4 to 158c74d Compare February 2, 2024 22:39
@timkpaine timkpaine added type: enhancement Issues and PRs related to improvements to existing features lang: python Issues and PRs related to the Python codebase labels Feb 2, 2024
@timkpaine timkpaine force-pushed the tkp/sqla2 branch 5 times, most recently from 4b79527 to a6bd893 Compare February 3, 2024 22:21
@timkpaine timkpaine marked this pull request as ready for review February 5, 2024 14:19
@timkpaine timkpaine force-pushed the tkp/sqla2 branch 3 times, most recently from e6b2647 to 5493750 Compare February 6, 2024 18:10
ngoldbaum
ngoldbaum reviewed Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw other warnings about uses of pkg_resources elsewhere, could fix them all at once later too. I didn't spot any other issues here.

csp/adapters/db.py Outdated Show resolved Hide resolved
csp/adapters/db.py Outdated Show resolved Hide resolved
@timkpaine timkpaine force-pushed the tkp/sqla2 branch 2 times, most recently from 38eb386 to ec4ed33 Compare February 7, 2024 01:41
timkpaine and others added 2 commits February 6, 2024 21:21
@timkpaine
Support sqlalchemy>=2
e61f3e7 
Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com>
@timkpaine
remove deprecated use of pkg_resources, switch to importlib
01b199d 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
ngoldbaum
ngoldbaum approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and looks like the tests are passing.

@timkpaine timkpaine merged commit a5a59d3 into main Feb 7, 2024
12 checks passed
@timkpaine timkpaine deleted the tkp/sqla2 branch February 7, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
lang: python Issues and PRs related to the Python codebase type: enhancement Issues and PRs related to improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @ngoldbaum