-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sympy integration via ufunc dispatch, expanded numpy
integration
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
added
type: feature
Issues and PRs related to new features
tag: wip
PRs that are a work in progress - converted to drafts
labels
Feb 10, 2024
timkpaine
changed the title
WIP sympy integration via ufunc dispatch
[WIP] sympy integration via ufunc dispatch
Feb 10, 2024
timkpaine
commented
Feb 10, 2024
timkpaine
force-pushed
the
tkp/sympy
branch
4 times, most recently
from
February 10, 2024 21:13
7741a53
to
b8c03e8
Compare
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Allow for only a single argument to be a numpy type, with required modifications to max and min to support this. Add numpy specializations - due to numpy's ufunc dispatch already deferring to numpy functions when applicable, this does not have a huge effect. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
commented
Feb 20, 2024
AdamGlustein
previously requested changes
Feb 20, 2024
…se big dict Signed-off-by: Tim Paine <timothy.paine@cubistsystematic.com>
…_, and __abs__ to pandas tsarray Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
changed the title
[WIP] sympy integration via ufunc dispatch
Sympy integration via ufunc dispatch, expanded Feb 20, 2024
numpy
integration
timkpaine
added
type: enhancement
Issues and PRs related to improvements to existing features
and removed
tag: wip
PRs that are a work in progress - converted to drafts
labels
Feb 20, 2024
AdamGlustein
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the comment on Edge modulus (it seems incorrectly implemented), other than that it lgtm.
… methods Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
AdamGlustein
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: enhancement
Issues and PRs related to improvements to existing features
type: feature
Issues and PRs related to new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just getting started on this but opening for visibility
fixes #59 eventually
fixes #63 as a side-effect
TODO after
csp.math
Proof of concept:
Here's the generated graph for e.g. black scholes, the left print is printing the spot price, the right is printing the calculated vanilla european call option price