-
Notifications
You must be signed in to change notification settings - Fork 72
Add unset field semantics for structs ("strict structs") #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simon Beyzerov <simon.beyzerov@point72.com>
…ance bug Signed-off-by: Adam Glustein <adam.glustein@point72.com>
Signed-off-by: Adam Glustein <adam.glustein@point72.com>
Signed-off-by: Adam Glustein <adam.glustein@point72.com>
|
Previously, when all fields on structs were optional, we hard-coded these two flags for pydantic validation
Can we only apply this logic when |
I tested out this approach and it doesn't validate correctly in the case of a required field with a default value. class MyStrictStruct(csp.Struct, allow_unset=False):
req_default_str: str = "default" |
Cleanup and a few fixes to #574, thanks @sim15 for the contribution!