Skip to content

Commit

Permalink
Moved -Werror from CMakeLists.txt to build scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
kunaltyagi committed Sep 27, 2019
1 parent e8b29cc commit 361e8c2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .ci/azure-pipelines/build-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
variables:
BUILD_DIR: '$(Agent.WorkFolder)/build'
GOOGLE_TEST_DIR: '$(Agent.WorkFolder)/googletest'
CMAKE_CXX_FLAGS: '-Wall -Wextra -Wabi -O2'
CMAKE_CXX_FLAGS: '-Wall -Wextra -Wabi -Werror -O2'
steps:
- script: |
brew install pkg-config qt5 libpcap brewsci/science/openni
Expand Down
2 changes: 1 addition & 1 deletion .ci/azure-pipelines/build-ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
container: env1604
variables:
BUILD_DIR: '$(Agent.BuildDirectory)/build'
CMAKE_CXX_FLAGS: '-Wall -Wextra -Wabi -O2'
CMAKE_CXX_FLAGS: '-Wall -Wextra -Wabi -Werror -O2'
steps:
- script: |
mkdir $BUILD_DIR && cd $BUILD_DIR
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ if(CMAKE_COMPILER_IS_GNUCXX)
else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wabi")
endif()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Werror -Wno-unknown-pragmas -fno-strict-aliasing -Wno-format-extra-args -Wno-sign-compare -Wno-invalid-offsetof -Wno-conversion ${SSE_FLAGS_STR}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-unknown-pragmas -fno-strict-aliasing -Wno-format-extra-args -Wno-sign-compare -Wno-invalid-offsetof -Wno-conversion ${SSE_FLAGS_STR}")
endif()

if("${CMAKE_SHARED_LINKER_FLAGS}" STREQUAL "" AND NOT CMAKE_SYSTEM_NAME STREQUAL "Darwin")
Expand Down

0 comments on commit 361e8c2

Please sign in to comment.