Merge pull request #3070 from SunBlack/readability-redundant-member-init

Remove redundant member init

apps/3d_rec_framework/src/tools/openni_frame_source.cpp

@@ -7,7 +7,7 @@ namespace OpenNIFrameSource
 {
 
   OpenNIFrameSource::OpenNIFrameSource (const std::string& device_id) :
-    grabber_ (device_id), most_recent_frame_ (), frame_counter_ (0), active_ (true)
+    grabber_ (device_id), frame_counter_ (0), active_ (true)
   {
     boost::function<void
     (const PointCloudConstPtr&)> frame_cb = boost::bind (&OpenNIFrameSource::onNewFrame, this, _1);

apps/cloud_composer/src/cloud_view.cpp

@@ -42,8 +42,7 @@ pcl::cloud_composer::CloudView::CloudView (ProjectModel* model, QWidget* parent)
 }
 
 pcl::cloud_composer::CloudView::CloudView (const CloudView& to_copy)
-  : QWidget ()
-  , vis_ (to_copy.vis_)
+  : vis_ (to_copy.vis_)
   , model_ (to_copy.model_)
   , qvtk_ (to_copy.qvtk_)
 {

apps/cloud_composer/src/point_selectors/click_trackball_interactor_style.cpp

@@ -13,7 +13,6 @@ namespace pcl
 }
 
 pcl::cloud_composer::ClickTrackballStyleInteractor::ClickTrackballStyleInteractor ()
-  : vtkInteractorStyleTrackballActor ()
 {
   manipulation_complete_event_ = interactor_events::MANIPULATION_COMPLETE_EVENT;
   start_matrix_= vtkSmartPointer<vtkMatrix4x4>::New ();

apps/cloud_composer/src/point_selectors/rectangular_frustum_selector.cpp

@@ -12,7 +12,6 @@ namespace pcl
 }
 
 pcl::cloud_composer::RectangularFrustumSelector::RectangularFrustumSelector ()
-  : vtkInteractorStyleRubberBandPick ()
 {
   selection_complete_event_ = interactor_events::SELECTION_COMPLETE_EVENT;
 }

apps/cloud_composer/src/point_selectors/selected_trackball_interactor_style.cpp

@@ -13,7 +13,6 @@ namespace pcl
 }
 
 pcl::cloud_composer::SelectedTrackballStyleInteractor::SelectedTrackballStyleInteractor ()
-  : vtkInteractorStyleTrackballActor ()
 {
   manipulation_complete_event_ = interactor_events::MANIPULATION_COMPLETE_EVENT;  
 }

apps/cloud_composer/src/project_model.cpp

@@ -53,7 +53,6 @@ pcl::cloud_composer::ProjectModel::ProjectModel (QObject* parent)
 }
 
 pcl::cloud_composer::ProjectModel::ProjectModel (const ProjectModel&)
-  : QStandardItemModel ()
 {
 }
 

apps/cloud_composer/src/properties_model.cpp

@@ -22,7 +22,6 @@ pcl::cloud_composer::PropertiesModel::PropertiesModel (CloudComposerItem* parent
 }
 
 pcl::cloud_composer::PropertiesModel::PropertiesModel (const PropertiesModel& to_copy)
-  : QStandardItemModel ()
 {
   for (int i=0; i < to_copy.rowCount (); ++i){
     QList <QStandardItem*> new_row;

apps/cloud_composer/src/toolbox_model.cpp

@@ -17,7 +17,6 @@ pcl::cloud_composer::ToolBoxModel::ToolBoxModel (QTreeView* tool_view, QTreeView
 }
 
 pcl::cloud_composer::ToolBoxModel::ToolBoxModel (const ToolBoxModel&)
-  : QStandardItemModel ()
 {
 }
 

apps/in_hand_scanner/include/pcl/apps/in_hand_scanner/in_hand_scanner.h

@@ -216,15 +216,15 @@ namespace pcl
         class ComputationFPS : public Base::FPS
         {
           public:
-            ComputationFPS () : Base::FPS () {}
+            ComputationFPS () {}
             ~ComputationFPS () {}
         };
 
         /** \brief Helper object for the visualization thread. Please have a look at the documentation of calcFPS. */
         class VisualizationFPS : public Base::FPS
         {
           public:
-            VisualizationFPS () : Base::FPS () {}
+            VisualizationFPS () {}
             ~VisualizationFPS () {}
         };
 

apps/in_hand_scanner/include/pcl/apps/in_hand_scanner/offline_integration.h

@@ -131,7 +131,7 @@ namespace pcl
         class ComputationFPS : public Base::FPS
         {
           public:
-            ComputationFPS () : Base::FPS () {}
+            ComputationFPS () {}
             ~ComputationFPS () {}
         };
 
@@ -140,7 +140,7 @@ namespace pcl
         class VisualizationFPS : public Base::FPS
         {
           public:
-            VisualizationFPS () : Base::FPS () {}
+            VisualizationFPS () {}
             ~VisualizationFPS () {}
         };
 

apps/in_hand_scanner/src/in_hand_scanner.cpp

@@ -63,14 +63,9 @@
 
 pcl::ihs::InHandScanner::InHandScanner (Base* parent)
   : Base                   (parent),
-    mutex_                 (),
-    computation_fps_       (),
-    visualization_fps_     (),
     running_mode_          (RM_UNPROCESSED),
     iteration_             (0),
-    grabber_               (),
     starting_grabber_      (false),
-    new_data_connection_   (),
     input_data_processing_ (new InputDataProcessing ()),
     icp_                   (new ICP ()),
     transformation_        (Eigen::Matrix4f::Identity ()),

apps/in_hand_scanner/src/offline_integration.cpp

@@ -61,11 +61,6 @@
 
 pcl::ihs::OfflineIntegration::OfflineIntegration (Base* parent)
   : Base               (parent),
-    mutex_             (),
-    mutex_quit_        (),
-    computation_fps_   (),
-    visualization_fps_ (),
-    path_dir_          (),
     mesh_model_        (new Mesh ()),
     normal_estimation_ (new NormalEstimation ()),
     integration_       (new Integration ()),

apps/in_hand_scanner/src/opengl_viewer.cpp

@@ -64,17 +64,14 @@
 ////////////////////////////////////////////////////////////////////////////////
 
 pcl::ihs::detail::FaceVertexMesh::FaceVertexMesh ()
-  : vertices       (),
-    triangles      (),
-    transformation (Eigen::Isometry3d::Identity ())
+  : transformation (Eigen::Isometry3d::Identity ())
 {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 pcl::ihs::detail::FaceVertexMesh::FaceVertexMesh (const Mesh& mesh, const Eigen::Isometry3d& T)
   : vertices       (mesh.getVertexDataCloud ()),
-    triangles      (),
     transformation (T)
 {
   if (typeid (Mesh::MeshTag) != typeid (pcl::geometry::TriangleMeshTag))
@@ -108,15 +105,12 @@ pcl::ihs::detail::FaceVertexMesh::FaceVertexMesh (const Mesh& mesh, const Eigen:
 
 pcl::ihs::OpenGLViewer::OpenGLViewer (QWidget* parent)
   : QGLWidget            (parent),
-    mutex_vis_           (),
     timer_vis_           (new QTimer (this)),
     colormap_            (Colormap::Constant (255)),
     vis_conf_norm_       (1),
-    drawn_meshes_        (),
     mesh_representation_ (MR_POINTS),
     coloring_            (COL_RGB),
     draw_box_            (false),
-    box_coefficients_    (),
     scaling_factor_      (1.),
     R_cam_               (1., 0., 0., 0.),
     t_cam_               (0., 0., 0.),

apps/include/pcl/apps/nn_classification.h

@@ -67,7 +67,7 @@ namespace pcl
 
     public:
 
-      NNClassification () : tree_ (), classes_ (), labels_idx_ () {}
+      NNClassification () : tree_ () {}
 
       /** \brief Result is a list of class labels and scores */
       typedef std::pair<std::vector<std::string>, std::vector<float> > Result;

apps/include/pcl/apps/vfh_nn_classifier.h

@@ -110,7 +110,7 @@ namespace pcl
 
     public:
 
-      VFHClassifierNN () : training_features_ (), labels_ (), classifier_ ()
+      VFHClassifierNN ()
       {
         reset ();
       }

apps/modeler/include/pcl/apps/modeler/main_window.h

@@ -128,7 +128,7 @@ namespace pcl
         friend class AbstractItem;
 
         MainWindow();
-        MainWindow(const MainWindow &) : QMainWindow () {}            // copy ctor hidden
+        MainWindow(const MainWindow &) {} // copy ctor hidden
         MainWindow& operator=(const MainWindow &) { return (*this); } // assign op. hidden
         ~MainWindow();
 

apps/modeler/src/channel_actor_item.cpp

@@ -52,7 +52,6 @@ pcl::modeler::ChannelActorItem::ChannelActorItem(QTreeWidgetItem* parent,
   const vtkSmartPointer<vtkActor>& actor,
   const std::string& channel_name)
   :QTreeWidgetItem(parent),
-  AbstractItem(),
   cloud_mesh_(cloud_mesh),
   poly_data_(vtkSmartPointer<vtkPolyData>::New()),
   render_window_(render_window),

apps/modeler/src/cloud_mesh_item.cpp

@@ -51,7 +51,6 @@
 //////////////////////////////////////////////////////////////////////////////////////////////
 pcl::modeler::CloudMeshItem::CloudMeshItem (QTreeWidgetItem* parent, const std::string& filename)
   :QTreeWidgetItem(parent),
-  AbstractItem(),
   filename_(filename),
   cloud_mesh_(new CloudMesh),
   translation_x_(new DoubleParameter("Translation X", "Translation X", 0.0, -1.0, 1.0)),
@@ -68,7 +67,6 @@ pcl::modeler::CloudMeshItem::CloudMeshItem (QTreeWidgetItem* parent, const std::
 //////////////////////////////////////////////////////////////////////////////////////////////
 pcl::modeler::CloudMeshItem::CloudMeshItem (QTreeWidgetItem* parent, CloudMesh::PointCloudPtr cloud)
   :QTreeWidgetItem(parent),
-  AbstractItem(),
   filename_("unnamed point cloud"),
   cloud_mesh_(new CloudMesh (cloud)),
   translation_x_(new DoubleParameter("Translation X", "Translation X", 0.0, -1.0, 1.0)),
@@ -89,7 +87,6 @@ pcl::modeler::CloudMeshItem::CloudMeshItem (QTreeWidgetItem* parent, CloudMesh::
 //////////////////////////////////////////////////////////////////////////////////////////////
 pcl::modeler::CloudMeshItem::CloudMeshItem(QTreeWidgetItem* parent,  const CloudMeshItem& cloud_mesh_item)
   :QTreeWidgetItem(parent),
-  AbstractItem(),
   filename_(cloud_mesh_item.filename_),
   cloud_mesh_(cloud_mesh_item.cloud_mesh_),
   translation_x_(new DoubleParameter("Translation X", "Translation X", 0.0, -1.0, 1.0)),

apps/modeler/src/render_window_item.cpp

@@ -45,7 +45,6 @@
 //////////////////////////////////////////////////////////////////////////////////////////////
 pcl::modeler::RenderWindowItem::RenderWindowItem(QTreeWidget * parent)
   : QTreeWidgetItem(parent),
-  AbstractItem(),
   render_window_(new RenderWindow(this)),
   background_color_(new ColorParameter("Background Color", "The background color of the render window", QColor(0, 0, 0))),
   show_axes_(new BoolParameter("Show Axes", "Show Axes", true))

apps/src/face_detection/openni_frame_source.cpp

@@ -7,7 +7,7 @@ namespace OpenNIFrameSource
 {
 
   OpenNIFrameSource::OpenNIFrameSource(const std::string& device_id) :
-      grabber_ (device_id), most_recent_frame_ (), frame_counter_ (0), active_ (true)
+      grabber_ (device_id), frame_counter_ (0), active_ (true)
   {
     boost::function<void(const PointCloudConstPtr&)> frame_cb = boost::bind (&OpenNIFrameSource::onNewFrame, this, _1);
     grabber_.registerCallback (frame_cb);

apps/src/ni_agast.cpp

@@ -76,7 +76,6 @@ class AGASTDemo
       , bmax_ (255)
       , threshold_ (30)
       , detector_type_ (0)
-      , timer_ ()
     {
     }
 

apps/src/openni_fast_mesh.cpp

@@ -73,7 +73,7 @@ class OpenNIFastMesh
     typedef typename Cloud::ConstPtr CloudConstPtr;
 
     OpenNIFastMesh (const std::string& device_id = "")
-      : device_id_(device_id), vertices_ ()
+      : device_id_(device_id)
     {
       ofm.setTrianglePixelSize (3);
       ofm.setTriangulationType (pcl::OrganizedFastMesh<PointType>::QUAD_MESH);

apps/src/openni_klt.cpp

@@ -109,8 +109,7 @@ class OpenNIViewer
     typedef typename Cloud::ConstPtr CloudConstPtr;
 
     OpenNIViewer (pcl::Grabber& grabber)
-      : image_viewer_ ()
-      , grabber_ (grabber)
+      : grabber_ (grabber)
       , rgb_data_ (nullptr), rgb_data_size_ (0)
     { }
 

apps/src/openni_passthrough.cpp

@@ -52,12 +52,7 @@ using namespace std::chrono_literals;
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 OpenNIPassthrough::OpenNIPassthrough (pcl::OpenNIGrabber& grabber) 
-  : vis_ ()
-  , grabber_(grabber)
-  , device_id_ ()
-  , cloud_pass_()
-  , pass_ ()
-  , mtx_ ()
+  : grabber_(grabber)
   , ui_ (new Ui::MainWindow)
   , vis_timer_ (new QTimer (this))
 {

common/include/pcl/ModelCoefficients.h

@@ -11,7 +11,7 @@ namespace pcl
 {
   struct ModelCoefficients
   {
-    ModelCoefficients () : header (), values ()
+    ModelCoefficients ()
     {
     }
 

common/include/pcl/PCLHeader.h

@@ -14,7 +14,7 @@ namespace pcl
 {
   struct PCLHeader
   {
-    PCLHeader (): seq (0), stamp (), frame_id ()
+    PCLHeader (): seq (0), stamp ()
     {}
 
     /** \brief Sequence number */

common/include/pcl/PCLImage.h

@@ -15,8 +15,8 @@ namespace pcl
 {
   struct PCLImage
   {
-    PCLImage () : header (), height (0), width (0), encoding (),
-               is_bigendian (0), step (0), data ()
+    PCLImage () : height (0), width (0),
+               is_bigendian (0), step (0)
     {}
 
      ::pcl::PCLHeader  header;

common/include/pcl/PCLPointCloud2.h

@@ -18,9 +18,9 @@ namespace pcl
 
   struct PCLPointCloud2
   {
-    PCLPointCloud2 () : header (), height (0), width (0), fields (),
+    PCLPointCloud2 () : height (0), width (0), 
                      is_bigendian (false), point_step (0), row_step (0),
-                     data (), is_dense (false)
+                     is_dense (false)
     {
 #if BOOST_ENDIAN_BIG_BYTE
       is_bigendian = true;

common/include/pcl/PCLPointField.h

@@ -14,7 +14,7 @@ namespace pcl
 {
   struct PCLPointField
   {
-    PCLPointField () : name (), offset (0), datatype (0), count (0)
+    PCLPointField () : offset (0), datatype (0), count (0)
     {}
 
     std::string name;

common/include/pcl/PointIndices.h

@@ -11,7 +11,7 @@ namespace pcl
 {
   struct PointIndices
   {
-    PointIndices () : header (), indices ()
+    PointIndices ()
     {}
 
     ::pcl::PCLHeader header;

common/include/pcl/PolygonMesh.h

@@ -14,7 +14,7 @@ namespace pcl
 {
   struct PolygonMesh
   {
-    PolygonMesh () : header (), cloud (), polygons ()
+    PolygonMesh ()
     {}
 
     ::pcl::PCLHeader  header;

common/include/pcl/TextureMesh.h

@@ -48,7 +48,7 @@ namespace pcl
   /** \author Khai Tran */
   struct TexMaterial
   {
-    TexMaterial () : tex_name (), tex_file (), tex_Ka (), tex_Kd (), tex_Ks (), tex_d (), tex_Ns (), tex_illum () {}
+    TexMaterial () : tex_Ka (), tex_Kd (), tex_Ks (), tex_d (), tex_Ns (), tex_illum () {}
 
     struct RGB
     {
@@ -89,8 +89,7 @@ namespace pcl
   /** \author Khai Tran */
   struct TextureMesh
   {
-    TextureMesh () : 
-      cloud (), tex_polygons (), tex_coordinates (), tex_materials () {}
+    TextureMesh () {}
 
     pcl::PCLPointCloud2  cloud;
     pcl::PCLHeader  header;

common/include/pcl/Vertices.h

@@ -13,7 +13,7 @@ namespace pcl
     */
   struct Vertices
   {
-    Vertices () : vertices ()
+    Vertices ()
     {}
 
     std::vector<uint32_t> vertices;

common/include/pcl/common/pca.h

@@ -89,10 +89,6 @@ namespace pcl
         : Base ()
         , compute_done_ (false)
         , basis_only_ (basis_only) 
-        , eigenvectors_ ()
-        , coefficients_ ()
-        , mean_ ()
-        , eigenvalues_  ()
       {}
 
       /** Copy Constructor

common/include/pcl/common/synchronizer.h

@@ -64,7 +64,7 @@ namespace pcl
     int callback_counter;
   public:
 
-    Synchronizer () : mutex1_ (), mutex2_ (), publish_mutex_ (), queueT1 (), queueT2 (), cb_ (), callback_counter (0) { };
+    Synchronizer () : queueT1 (), queueT2 (), cb_ (), callback_counter (0) { };
 
     int
     addCallback (const CallbackFunction& callback)