Skip to content

Commit

Permalink
Merge pull request #2070 from SergioRAgostinho/pca_deprecated
Browse files Browse the repository at this point in the history
Removal of PCA deprecated constructor
  • Loading branch information
taketwo authored Nov 10, 2017
2 parents b1dc9f5 + 856812a commit 7e4f72e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
14 changes: 0 additions & 14 deletions common/include/pcl/common/impl/pca.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,6 @@
#include <pcl/common/transforms.h>
#include <pcl/exceptions.h>

/////////////////////////////////////////////////////////////////////////////////////////
/** \brief Constructor with direct computation
* \param[in] cloud input m*n matrix (ie n vectors of R(m))
* \param[in] basis_only flag to compute only the PCA basis
*/
template<typename PointT>
pcl::PCA<PointT>::PCA (const pcl::PointCloud<PointT> &cloud, bool basis_only)
{
Base ();
basis_only_ = basis_only;
setInputCloud (cloud.makeShared ());
compute_done_ = initCompute ();
}

/////////////////////////////////////////////////////////////////////////////////////////
template<typename PointT> bool
pcl::PCA<PointT>::initCompute ()
Expand Down
7 changes: 0 additions & 7 deletions common/include/pcl/common/pca.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,6 @@ namespace pcl
, mean_ ()
, eigenvalues_ ()
{}

/** \brief Constructor with direct computation
* X input m*n matrix (ie n vectors of R(m))
* basis_only flag to compute only the PCA basis
*/
PCL_DEPRECATED ("Use PCA (bool basis_only); setInputCloud (X.makeShared ()); instead")
PCA (const pcl::PointCloud<PointT>& X, bool basis_only = false);

/** Copy Constructor
* \param[in] pca PCA object
Expand Down

0 comments on commit 7e4f72e

Please sign in to comment.