Fix base class should be explicitly initialized in copy constructor

apps/cloud_composer/include/pcl/apps/cloud_composer/project_model.h

@@ -69,7 +69,6 @@ namespace pcl
 
       public:
         ProjectModel (QObject *parent = nullptr);
-        ProjectModel (const ProjectModel& to_copy);
         ~ProjectModel ();
 
         ProjectModel (QString project_name, QObject *parent = nullptr);

apps/cloud_composer/include/pcl/apps/cloud_composer/toolbox_model.h

@@ -69,8 +69,6 @@ namespace pcl
 
     public:
       ToolBoxModel (QTreeView* tool_view = nullptr, QTreeView* parameter_view = nullptr, QObject *parent = nullptr);
-      ToolBoxModel (const ToolBoxModel& to_copy);
-      ~ToolBoxModel ();
 
       void
       addTool (ToolFactory* tool_factory);

apps/cloud_composer/src/cloud_view.cpp

@@ -42,7 +42,8 @@ pcl::cloud_composer::CloudView::CloudView (ProjectModel* model, QWidget* parent)
 }
 
 pcl::cloud_composer::CloudView::CloudView (const CloudView& to_copy)
-  : vis_ (to_copy.vis_)
+  : QWidget (to_copy)
+  , vis_ (to_copy.vis_)
   , model_ (to_copy.model_)
   , qvtk_ (to_copy.qvtk_)
 {

apps/cloud_composer/src/project_model.cpp

@@ -52,10 +52,6 @@ pcl::cloud_composer::ProjectModel::ProjectModel (QObject* parent)
   selected_style_map_.insert (interactor_styles::SELECTED_TRACKBALL, false);
 }
 
-pcl::cloud_composer::ProjectModel::ProjectModel (const ProjectModel&)
-{
-}
-
 pcl::cloud_composer::ProjectModel::~ProjectModel ()
 {
   work_thread_->quit ();

apps/cloud_composer/src/toolbox_model.cpp

@@ -16,14 +16,6 @@ pcl::cloud_composer::ToolBoxModel::ToolBoxModel (QTreeView* tool_view, QTreeView
 
 }
 
-pcl::cloud_composer::ToolBoxModel::ToolBoxModel (const ToolBoxModel&)
-{
-}
-
-pcl::cloud_composer::ToolBoxModel::~ToolBoxModel ()
-{
-}
-
 void
 pcl::cloud_composer::ToolBoxModel::addTool (ToolFactory* tool_factory)
 {

apps/modeler/include/pcl/apps/modeler/main_window.h

@@ -128,8 +128,7 @@ namespace pcl
         friend class AbstractItem;
 
         MainWindow();
-        MainWindow(const MainWindow &) {} // copy ctor hidden
-        MainWindow& operator=(const MainWindow &) { return (*this); } // assign op. hidden
+        MainWindow(const MainWindow &) = delete;
         ~MainWindow();
 
         Ui::MainWindow                    *ui_; // Designer form

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/cloud.h

@@ -90,9 +90,6 @@ class Cloud : public Statistics
     /// variables of this object are initialized but not set.
     Cloud (const Cloud3D& cloud, bool register_stats=false);
 
-    /// @brief Destructor
-    ~Cloud ();
-
     /// @brief Equal Operator
     /// @details Deep copies all the state of the passed cloud to this cloud.
     /// @param cloud The cloud object whose status to be copied to this object

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/copyCommand.h

@@ -60,11 +60,13 @@ class CopyCommand : public Command
       has_undo_ = false;
     }
 
-    /// @brief Destructor
-    ~CopyCommand ()
-    {
-    }
-
+    /// @brief Copy constructor - commands are non-copyable
+    CopyCommand (const CopyCommand&) = delete;
+
+    /// @brief Equal operator - commands are non-copyable
+    CopyCommand&
+    operator= (const CopyCommand&) = delete;
+
   protected:
     /// @brief Copy the selected points into the copy buffer.
     /// @pre Assumes the constructor was given appropriate pointers to the
@@ -85,25 +87,6 @@ class CopyCommand : public Command
     }
 
   private:
-    /// @brief Default constructor - object is not default constructable
-    CopyCommand ()
-    {
-      assert(false);
-    }
-
-    /// @brief Copy constructor - commands are non-copyable
-    CopyCommand (const CopyCommand&)
-    {
-      assert(false);
-    }
-
-    /// @brief Equal operator - commands are non-copyable
-    CopyCommand&
-    operator= (const CopyCommand&)
-    {
-      assert(false); return (*this);
-    }
-
     /// a pointer to the copy buffer.
     CopyBufferPtr copy_buffer_ptr_;
 

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/cutCommand.h

@@ -56,6 +56,13 @@ class CutCommand : public Command
                 SelectionPtr selection_ptr,
                 CloudPtr cloud_ptr);
 
+    /// @brief Copy constructor - commands are non-copyable
+    CutCommand (const CutCommand&) = delete;
+
+    /// @brief Equal operator - commands are non-copyable
+    CutCommand&
+    operator= (const CutCommand&) = delete;
+
     /// @brief Destructor
     ~CutCommand ();
 
@@ -73,25 +80,6 @@ class CutCommand : public Command
     undo () override;
 
   private:
-    /// @brief Default constructor - object is not default constructable
-    CutCommand () : cut_selection_(CloudPtr())
-    {
-      assert(false);
-    }
-
-    /// @brief Copy constructor - commands are non-copyable
-    CutCommand (const CutCommand&) : cut_selection_(CloudPtr())
-    {
-      assert(false);
-    }
-
-    /// @brief Equal operator - commands are non-copyable
-    CutCommand&
-    operator= (const CutCommand&)
-    {
-      assert(false); return (*this);
-    }
-
     /// A shared pointer pointing to the selection object.
     SelectionPtr selection_ptr_;
 
@@ -107,5 +95,4 @@ class CutCommand : public Command
 
     /// The copy buffer which backs up the points removed from the cloud.
     CopyBuffer cut_cloud_buffer_;
-
 };

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/deleteCommand.h

@@ -52,12 +52,14 @@ class DeleteCommand : public Command
     /// @param selection_ptr A shared pointer pointing to the selection object.
     /// @param cloud_ptr A shared pointer pointing to the cloud object.
     DeleteCommand (SelectionPtr selection_ptr, CloudPtr cloud_ptr);
-
-    /// @brief Destructor
-    ~DeleteCommand ()
-    {
-    }
-
+
+    /// @brief Copy constructor - commands are non-copyable
+    DeleteCommand (const DeleteCommand& c) = delete;
+
+    /// @brief Equal operator - commands are non-copyable
+    DeleteCommand&
+    operator= (const DeleteCommand&) = delete;
+
   protected:
     /// @brief Removes the selected points and maintains a backup for undo.
     void 
@@ -68,26 +70,6 @@ class DeleteCommand : public Command
     undo () override;
 
   private:
-    /// @brief Default constructor - object is not default constructable
-    DeleteCommand ():  deleted_selection_(CloudPtr())
-    {
-      assert(false);
-    }
-
-    /// @brief Copy constructor - commands are non-copyable
-    DeleteCommand (const DeleteCommand& c)
-      : deleted_selection_(c.deleted_selection_)
-    {
-      assert(false);
-    }
-
-    /// @brief Equal operator - commands are non-copyable
-    DeleteCommand&
-    operator= (const DeleteCommand&)
-    {
-      assert(false); return (*this);
-    }
-
     /// a pointer pointing to the cloud
     CloudPtr cloud_ptr_;
 

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/denoiseCommand.h

@@ -62,10 +62,12 @@ class DenoiseCommand : public Command
   {
   }
 
-  /// @brief Destructor
-  ~DenoiseCommand ()
-  {
-  }
+  /// @brief Copy constructor - commands are non-copyable
+  DenoiseCommand (const DenoiseCommand&) = delete;
+
+  /// @brief Equal operator - commands are non-copyable
+  DenoiseCommand&
+  operator= (const DenoiseCommand&) = delete;
 
 protected:
   /// @brief Runs the denois algorithm to remove all the outliers.
@@ -77,25 +79,6 @@ class DenoiseCommand : public Command
   undo () override;
 
 private:
-  /// @brief Default Constructor
-  DenoiseCommand () : removed_indices_(CloudPtr())
-  {
-  }
-
-  /// @brief Copy constructor - commands are non-copyable
-  DenoiseCommand (const DenoiseCommand&)
-    : removed_indices_(CloudPtr())
-  {
-    assert(false);
-  }
-
-  /// @brief Equal operator - commands are non-copyable
-  DenoiseCommand&
-  operator= (const DenoiseCommand&)
-  {
-    assert(false); return (*this);
-  }
-
   /// A shared pointer pointing to the selection object of the widget
   SelectionPtr selection_ptr_;
 

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/pasteCommand.h

@@ -54,10 +54,12 @@ class PasteCommand : public Command
                   SelectionPtr selection_ptr, CloudPtr cloud_ptr);
     // comment that the selection is updated (also resets the matrix in cloud)
 
-    /// @brief Destructor
-    ~PasteCommand ()
-    {
-    }
+    /// @brief Copy constructor - commands are non-copyable
+    PasteCommand (const PasteCommand&) = delete;
+
+    /// @brief Equal operator - commands are non-copyable
+    PasteCommand&
+    operator= (const PasteCommand&) = delete;
 
   protected:
     /// @brief Appends the points in the copy buffer into the cloud.
@@ -71,25 +73,7 @@ class PasteCommand : public Command
     void
     undo () override;
 
-  private:
-    /// @brief Default constructor - object is not default constructable
-    PasteCommand ()
-    {
-    }
-
-    /// @brief Copy constructor - commands are non-copyable
-    PasteCommand (const PasteCommand&)
-    {
-      assert(false);
-    }
-
-    /// @brief Equal operator - commands are non-copyable
-    PasteCommand&
-    operator= (const PasteCommand&)
-    {
-      assert(false); return (*this);
-    }
-
+  private:    
     /// a pointer pointing to the copy buffer.
     ConstCopyBufferPtr copy_buffer_ptr_;
 

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/selection.h

@@ -63,12 +63,7 @@ class Selection : public Statistics
     /// @brief Copy constructor
     /// @param copy The selection object to be copied
     Selection (const Selection& copy)
-      : cloud_ptr_(copy.cloud_ptr_), selected_indices_(copy.selected_indices_)
-    {
-    }
-
-    /// @brief Destructor.
-    ~Selection ()
+      : Statistics (copy), cloud_ptr_(copy.cloud_ptr_), selected_indices_(copy.selected_indices_)
     {
     }
 

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/transformCommand.h

@@ -56,10 +56,12 @@ class TransformCommand : public Command
                       const float* matrix, float translate_x,
                       float translate_y, float translate_z);
 
-    /// @brief Destructor
-    ~TransformCommand ()
-    {
-    }
+    /// @brief Copy constructor  - object is not copy-constructable
+    TransformCommand (const TransformCommand&) = delete;
+
+    /// @brief Equal operator - object is non-copyable
+    TransformCommand&
+    operator= (const TransformCommand&) = delete;
 
   protected:
     // Transforms the coorindates of the selected points according to the transform
@@ -72,18 +74,6 @@ class TransformCommand : public Command
     undo () override;
 
   private:
-    /// @brief Copy constructor  - object is not copy-constructable
-    TransformCommand (const TransformCommand&)
-    {
-    }
-
-    /// @brief Equal operator - object is non-copyable
-    TransformCommand&
-    operator= (const TransformCommand&)
-    {
-      assert(false); return (*this);
-    }
-
     /// @brief Applies the transformation to the point values
     /// @param sel_ptr A pointer to the selection object whose points are to be
     /// transformed.

apps/point_cloud_editor/src/cloud.cpp

@@ -98,7 +98,8 @@ Cloud::Cloud (const Cloud3D &cloud, bool register_stats)
 }
 
 Cloud::Cloud (const Cloud &copy)
-  : cloud_(copy.cloud_), selection_wk_ptr_(copy.selection_wk_ptr_),
+  : Statistics(copy)
+  cloud_(copy.cloud_), selection_wk_ptr_(copy.selection_wk_ptr_),
   use_color_ramp_(copy.use_color_ramp_),
   color_ramp_axis_(copy.color_ramp_axis_),
   display_scale_(copy.display_scale_),
@@ -117,8 +118,6 @@ Cloud::Cloud (const Cloud &copy)
   std::copy(copy.highlight_color_, copy.highlight_color_+RGB, highlight_color_);
 }
 
-Cloud::~Cloud () {}
-
 Cloud&
 Cloud::operator= (const Cloud &cloud)
 {

apps/point_cloud_editor/src/copyBuffer.cpp

@@ -43,6 +43,7 @@
 #include <pcl/apps/point_cloud_editor/common.h>
 
 CopyBuffer::CopyBuffer (const CopyBuffer& copy_buffer) :
+  Statistics(copy_buffer),
   buffer_(copy_buffer.buffer_)
 {
 }