Fixed all passedByValue hints by CppCheck 1.85

apps/src/openni_grab_frame.cpp

@@ -220,7 +220,7 @@ class OpenNIGrabFrame
     }
 
     void
-    setOptions (std::string filename, std::string pcd_format, bool paused, bool visualizer)
+    setOptions (const std::string &filename, const std::string &pcd_format, bool paused, bool visualizer)
     {
       boost::filesystem::path path(filename);
 

apps/src/openni_octree_compression.cpp

@@ -122,7 +122,7 @@ do \
 }while(false)
 
 void
-print_usage (std::string msg)
+print_usage (const std::string &msg)
 {
   std::cerr << msg << std::endl;
   std::cout << usage << std::endl;

apps/src/openni_organized_compression.cpp

@@ -105,7 +105,7 @@ do \
 }while(false)
 
 void
-print_usage (std::string msg)
+print_usage (const std::string &msg)
 {
   std::cerr << msg << std::endl;
   std::cout << usage << std::endl;

apps/src/openni_tracking.cpp

@@ -509,7 +509,7 @@ class OpenNISegmentTracking
   }
 
   void extractSegmentCluster (const CloudConstPtr &cloud,
-                              const std::vector<pcl::PointIndices> cluster_indices,
+                              const std::vector<pcl::PointIndices> &cluster_indices,
                               const int segment_index,
                               Cloud &result)
   {

apps/src/stereo_ground_segmentation.cpp

@@ -100,7 +100,7 @@ class HRCSSegmentation
     int smooth_strong;
 
   public:
-    HRCSSegmentation (std::vector<std::string> left_images, std::vector<std::string> right_images) :
+    HRCSSegmentation (const std::vector<std::string> &left_images, const std::vector<std::string> &right_images) :
       viewer (new pcl::visualization::PCLVisualizer ("3D Viewer")),
       image_viewer (new pcl::visualization::ImageViewer ("Image Viewer")),
       prev_cloud (new pcl::PointCloud<PointT>),

doc/tutorials/content/sources/davidsdk/davidsdk_images_viewer.cpp

@@ -15,7 +15,7 @@ pcl::DavidSDKGrabber::Ptr davidsdk_ptr;
  * @returns the OpenCV type
  */
 int
-getOpenCVType (std::string type)
+getOpenCVType (const std::string &type)
 {
   if (type == "CV_32FC1")
     return CV_32FC1;

doc/tutorials/content/sources/ensenso_cameras/ensenso_cloud_images_viewer.cpp

@@ -40,7 +40,7 @@ pcl::EnsensoGrabber::Ptr ensenso_ptr;
  * @returns the OpenCV type
  */
 int
-getOpenCVType (std::string type)
+getOpenCVType (const std::string &type)
 {
   if (type == "CV_32FC1")
     return CV_32FC1;

examples/segmentation/example_supervoxels.cpp

@@ -71,7 +71,7 @@ void removeText (boost::shared_ptr<pcl::visualization::PCLVisualizer> viewer);
  * \param[in] field_name Fieldname to check
  * \return True if field has been found, false otherwise */
 bool
-hasField (const pcl::PCLPointCloud2 &pc2, const std::string field_name);
+hasField (const pcl::PCLPointCloud2 &pc2, const std::string &field_name);
 
 
 using namespace pcl;
@@ -559,7 +559,7 @@ void removeText (boost::shared_ptr<pcl::visualization::PCLVisualizer> viewer)
 }
 
 bool
-hasField (const pcl::PCLPointCloud2 &pc2, const std::string field_name)
+hasField (const pcl::PCLPointCloud2 &pc2, const std::string &field_name)
 {
   for (size_t cf = 0; cf < pc2.fields.size (); ++cf)
     if (pc2.fields[cf].name == field_name)

gpu/kinfu/tools/camera_pose.h

@@ -72,7 +72,7 @@ class CameraPoseWriter : public CameraPoseProcessor
     /**
        * @param output_filename name of file to write
        */
-    CameraPoseWriter (std::string output_filename) :
+    CameraPoseWriter (const std::string &output_filename) :
       output_filename_ (output_filename)
     {
       out_stream_.open (output_filename_.c_str () );

gpu/kinfu/tools/kinfu_app_sim.cpp

@@ -977,7 +977,7 @@ struct KinFuApp
   }
 
   void
-  execute (int argc, char** argv, std::string plyfile)
+  execute (int argc, char** argv, const std::string &plyfile)
   {
     PtrStepSz<const unsigned short> depth;
     PtrStepSz<const KinfuTracker::PixelRGB> rgb24;

gpu/kinfu_large_scale/tools/kinfu_app_sim.cpp

@@ -975,7 +975,7 @@ struct KinFuApp
   }
 
   void
-  execute (int argc, char** argv, std::string plyfile)
+  execute (int argc, char** argv, const std::string &plyfile)
   {
     PtrStepSz<const unsigned short> depth;
     PtrStepSz<const KinfuTracker::PixelRGB> rgb24;

simulation/tools/sim_terminal_demo.cpp

@@ -38,7 +38,7 @@ void printHelp (int, char **argv)
 
 
 // Output the simulated output to file:
-void write_sim_output(string fname_root){ 
+void write_sim_output(const string &fname_root){ 
   pcl::PointCloud<pcl::PointXYZRGB>::Ptr pc_out (new pcl::PointCloud<pcl::PointXYZRGB>);
 
   // Read Color Buffer from the GPU before creating PointCloud:

simulation/tools/sim_viewer.cpp

@@ -225,7 +225,7 @@ pp_callback (const pcl::visualization::PointPickingEvent& event, void* cookie)
   ph_global.spinOnce ();
 }
 
-void capture (Eigen::Isometry3d pose_in, string point_cloud_fname)
+void capture (Eigen::Isometry3d pose_in, const string &point_cloud_fname)
 {
   // No reference image - but this is kept for compatibility with range_test_v2:
   float* reference = new float[range_likelihood_->getRowHeight() * range_likelihood_->getColWidth()];

test/geometry/test_mesh_common_functions.h

@@ -53,7 +53,7 @@ const unsigned int max_number_boundary_vertices = 100;
 
 /** \brief Check if the faces of the mesh are equal to the reference faces (defined by a vector of vertices). */
 template <class MeshT> bool
-hasFaces (const MeshT& mesh, const std::vector <typename MeshT::VertexIndices> faces, const bool verbose = false)
+hasFaces (const MeshT& mesh, const std::vector <typename MeshT::VertexIndices> &faces, const bool verbose = false)
 {
   typedef typename MeshT::VertexAroundFaceCirculator VAFC;
   typedef typename MeshT::VertexIndices              VertexIndices;
@@ -114,7 +114,7 @@ hasFaces (const MeshT& mesh, const std::vector <typename MeshT::VertexIndices> f
  *  \note This method assumes that the vertex data is of type 'int'.
  */
 template <class MeshT> bool
-hasFaces (const MeshT& mesh, const std::vector <std::vector <int> > faces, const bool verbose = false)
+hasFaces (const MeshT& mesh, const std::vector <std::vector <int> > f&aces, const bool verbose = false)
 {
   typedef typename MeshT::VertexAroundFaceCirculator VAFC;
   typedef typename MeshT::FaceIndex                  FaceIndex;
@@ -293,7 +293,7 @@ isCircularPermutation (const ContainerT& expected, const ContainerT& actual, con
 
 /** \brief Check if both the inner and outer input vector are a circular permutation. */
 template <class ContainerT> bool
-isCircularPermutationVec (const std::vector <ContainerT> expected, const std::vector <ContainerT> actual, const bool verbose = false)
+isCircularPermutationVec (const std::vector <ContainerT> &expected, const std::vector <ContainerT> &actual, const bool verbose = false)
 {
   const unsigned int n = static_cast<unsigned int> (expected.size ());
   EXPECT_EQ (n, actual.size ());

tools/compute_cloud_error.cpp

@@ -82,7 +82,7 @@ loadCloud (const std::string &filename, pcl::PCLPointCloud2 &cloud)
 
 void
 compute (const pcl::PCLPointCloud2::ConstPtr &cloud_source, const pcl::PCLPointCloud2::ConstPtr &cloud_target,
-         pcl::PCLPointCloud2 &output, std::string correspondence_type)
+         pcl::PCLPointCloud2 &output, const std::string &correspondence_type)
 {
   // Estimate
   TicToc tt;

tools/morph.cpp

@@ -136,7 +136,7 @@ saveCloud (const std::string &filename, const Cloud &output)
 
 int
 batchProcess (const vector<string> &pcd_files, string &output_dir,
-              float resolution, std::string method)
+              float resolution, const std::string &method)
 {
   vector<string> st;
   for (size_t i = 0; i < pcd_files.size (); ++i)

tools/obj_rec_ransac_accepted_hypotheses.cpp

@@ -158,7 +158,7 @@ vtk_to_pointcloud (const char* file_name, PointCloud<PointXYZ>& pcl_points, Poin
 //===============================================================================================================================
 
 void
-showHypothesisAsCoordinateFrame (Hypothesis& hypo, CallbackParameters* parameters, string frame_name)
+showHypothesisAsCoordinateFrame (Hypothesis& hypo, CallbackParameters* parameters, const string &frame_name)
 {
   float rot_col[3], x_dir[3], y_dir[3], z_dir[3], origin[3], scale = 2.0f*parameters->objrec_.getPairWidth ();
   pcl::ModelCoefficients coeffs; coeffs.values.resize (6);

tools/passthrough_filter.cpp

@@ -125,7 +125,7 @@ saveCloud (const std::string &filename, const pcl::PCLPointCloud2 &output)
 
 int
 batchProcess (const vector<string> &pcd_files, string &output_dir,
-              std::string field_name, float min, float max, bool inside, bool keep_organized)
+              const std::string &field_name, float min, float max, bool inside, bool keep_organized)
 {
   vector<string> st;
   for (size_t i = 0; i < pcd_files.size (); ++i)

tools/tiff2pcd.cpp

@@ -61,13 +61,13 @@ using namespace pcl;
 
 void processAndSave( vtkSmartPointer<vtkImageData>  depth_data,
                      vtkSmartPointer<vtkImageData>  rgb_data,
-                     std::string                    time,
+                     const std::string&             time,
                      float                          focal_length,
                      bool                           format,
                      bool                           color,
                      bool                           depth,
                      bool                           use_output_path,
-                     std::string                    output_path)
+                     const std::string&             output_path)
 {
   // Retrieve the entries from the image data and copy them into the output RGB cloud
   int rgb_components = rgb_data->GetNumberOfScalarComponents();