Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird flying pixels in SupervoxelClustering #639

Closed
taketwo opened this issue Apr 13, 2014 · 5 comments
Closed

Weird flying pixels in SupervoxelClustering #639

taketwo opened this issue Apr 13, 2014 · 5 comments
Labels
kind: bug Type of issue

Comments

@taketwo
Copy link
Member

taketwo commented Apr 13, 2014

I encountered strange artifacts when running SupervoxelClustering on some of the scenes in OSD dataset (namely: 'learn5', 'learn25', 'learn26'):

selection_047

selection_046

Haven't had time to look closer yet.

@jpapon Any ideas?

@jpapon
Copy link
Contributor

jpapon commented Apr 14, 2014

I get the same behavior - it seems to be due to the depth transform. I'm looking into it...

@jpapon
Copy link
Contributor

jpapon commented Apr 14, 2014

So this is because these clouds have lots of points at 0,0,0 - and the transform used by supervoxels is x/=z,y/=z, and log z. As you might imagine, this results in some wonky behavior. It seems that at some point the sanitizing of input got removed... I'll add it back in.

@jpapon
Copy link
Contributor

jpapon commented Apr 14, 2014

This is fixed by commit c8fa843.

It was due to the bounding box getting screwed up by non-finite points in octree_adjacency after the transform. I'm not sure why they replaced nan points by points at 0,0,0 in the OSD dataset... but I've added a check to ensure that points are finite after the transform (which I should have been doing anyway).

@taketwo
Copy link
Member Author

taketwo commented Apr 14, 2014

Wow, thanks for taking care of this! I noticed the (0,0,0) thing in the OSD dataset before and also have no clue why they decided to do this.

I'll leave this issue open until the fix is merged.

@jspricke
Copy link
Member

jspricke commented Jun 3, 2014

@jpapon can you please send a pull request with the fix? Thanks!

jpapon added a commit to jpapon/pcl that referenced this issue Jun 3, 2014
@jspricke jspricke closed this as completed Jun 3, 2014
translunar pushed a commit to translunar/pcl that referenced this issue Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Type of issue
Projects
None yet
Development

No branches or pull requests

3 participants