Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCLVisualizer fixes #1142

Merged
merged 2 commits into from
Feb 25, 2015
Merged

PCLVisualizer fixes #1142

merged 2 commits into from
Feb 25, 2015

Conversation

VictorLamoine
Copy link
Contributor

The size of the model coefficients must be checked to avoid undefined behaviors.
I updated the documentation of addCone (which was false) and addCube; I redirect to shapes.cpp which has code examples.

The doc link have been tested.

@taketwo
Copy link
Member

taketwo commented Feb 12, 2015

Would it make sense to print a PCL_WARN? I doubt that people routinely check return value of addXXX() functions. Seeing a friendly message in console when they supply wrong coefficients will help them to localize the problem faster. (It's not obvious what is wrong when you just don't see anything it the visualizer after adding a shape.)

@VictorLamoine
Copy link
Contributor Author

Agreed!

taketwo added a commit that referenced this pull request Feb 25, 2015
@taketwo taketwo merged commit 8bf56db into PointCloudLibrary:master Feb 25, 2015
@VictorLamoine VictorLamoine deleted the pcl_visualizer branch February 25, 2015 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants