Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to allow OMP 2.0 compatibility #1214

Merged
merged 1 commit into from
Apr 29, 2015
Merged

Made changes to allow OMP 2.0 compatibility #1214

merged 1 commit into from
Apr 29, 2015

Conversation

mdering
Copy link
Contributor

@mdering mdering commented Apr 23, 2015

changed klt to use a vector instead of an array as a private variable,
for MSVC compatibility.

@mdering
Copy link
Contributor Author

mdering commented Apr 28, 2015

I'm confused, what happened with clang here? Ive been using clang on my own system, and its worked fine.

@VictorLamoine
Copy link
Contributor

It's a bug in Travis CI, ignore these kind of errors.

@mdering
Copy link
Contributor Author

mdering commented Apr 28, 2015

Ok, sounds good

@taketwo
Copy link
Member

taketwo commented Apr 28, 2015

Where is delete[] I wonder? So you fixed a memory leak along the way :)

Could you please add spaces around = and *?

@mdering
Copy link
Contributor Author

mdering commented Apr 28, 2015

That should do it.

@taketwo
Copy link
Member

taketwo commented Apr 28, 2015

Sorry, but I have to ask you to squash the commits into one. git rebase -i HEAD~2, mark the second one as a fixup, and push with force git push --force.

changed klt to use a vector instead of an array as a private variable,
for MSVC compatibility.
@mdering
Copy link
Contributor Author

mdering commented Apr 28, 2015

did that do it? Fixes #1208

taketwo added a commit that referenced this pull request Apr 29, 2015
Made changes to allow OMP 2.0 compatibility
@taketwo taketwo merged commit 34a4fd7 into PointCloudLibrary:master Apr 29, 2015
@taketwo
Copy link
Member

taketwo commented Apr 29, 2015

Thanks!

(Regarding "Fixes #1208": auto-close works only if this text is in the PR description, i.e. the very first comment.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants