Modification needed to prevent an out-of-bounds memory access condition #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspricke
added a commit
that referenced
this pull request
Oct 14, 2015
Modification needed to prevent an out-of-bounds memory access condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested modification fixes a gpu out-of-bounds memory access error that occurs sporadically. The cuda kernels for extractCloud and extractSliceAsCloud are affected. Immediately following the "for" loops associated with each change, is a out-of-bounds preventative check, which is fine where it is, but an additional check is also needed inside these "for" loops. I edited things a bit to make use of common variable labels and common logic, making these two little bits of code comparable.