LCCP preparation for CPC #1287
Merged
LCCP preparation for CPC #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** \brief Desribes if a connection is valid for the segment growing. Usually convex connections are and concave connection are not. Due to k-concavity a convex connection can be invalidated*/ | ||
| bool is_valid; | ||
| bool used_for_cutting; |
There was a problem hiding this comment.
Missing description here. Also missing c in "Desribes" above.
|
Thanks! Looks good, please fix the small issues and I'll merge. |
mschoeler
force-pushed
the
LCCP_changes
branch
2 times, most recently
from
94eaee2 to
51bbcf7
Compare
Small corrections to existing code, too.
|
ok changed it in several locations with uint32_t. Cheers |
|
mmh, do not know if this makes sense in all the locations I changed it. Maybe I can get your opinion on that :) |
|
For me all of them make sense, at least this is exactly what I normally do myself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to LCCP algorithm to prepare it as a base for CPC.
Small corrections to existing code, too.