getSampleSize issue #987 #1344
Closed
getSampleSize issue #987 #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Chose pure virtual bacause new models have to implement this method since SAC_SAMPLE_SIZE is const. * Implementations in the subclasses behave like the original implementation except for the exception message in case the model type is not found. * Changed verbosity level of selected samples from debug to verbose ! Fixed not initialized pointer in SampleConsensusModelCircle3d
|
Actually, there was a related discussion (#1075) about optimizing getting sample size performance and getting rid of the global map. Unfortunately, I hadn't have time to implement that approach, but it still seems preferential for me. |
|
@stefanbuettner would you be willing to redo this accoring to #1367? I think it would be clearer if we move the constants into the individual classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this is a suggestion to implement the issue #987 of declaring the getSampleSize as pure virtual.
Cheers,
Stefan