Added Velodyne VLP Grabber and example viewer #1452
Conversation
| , sweep_xyz_signal_ () | ||
| , sweep_xyzrgb_signal_ () | ||
| , sweep_xyzi_signal_ () | ||
| , scan_xyz_signal_ () | ||
| , scan_xyzrgb_signal_ () | ||
| , scan_xyzi_signal_ () | ||
| , hdl_data_ () | ||
| //, udp_listener_endpoint_ (getDefaultNetworkAddress(), HDL_DATA_PORT) |
There was a problem hiding this comment.
please don't submit commented code, we have a git for that ;).
|
Hi Keven, thanks for the pull request, can you please adpot it to the style guide: http://pointclouds.org/documentation/advanced/pcl_style_guide.php Thanks! |
| @@ -48,6 +48,11 @@ | |||
| #include <string> | |||
|
|
|||
| #define HDL_Grabber_toRadians(x) ((x) * M_PI / 180.0) | |||
| #define HDL_DATA_PORT 2368 | |||
There was a problem hiding this comment.
Why did you change protected static members into defines?
There was a problem hiding this comment.
When I originally kept it as a static const, the derived class wasn't seeing the constants. For whatever reason, it is now. Chalk it up to my inexperience with C++.
I'll convert them back to static const.
KevenRing
force-pushed
the
master
branch
2 times, most recently
from
50c9ac2 to
b74274e
Compare
| HDLLaserReturn laserReturn, | ||
| HDLLaserCorrection correction); | ||
|
|
||
| HDLLaserCorrection laser_corrections_[HDL_MAX_NUM_LASERS]; |
There was a problem hiding this comment.
Why do you make all these public?
There was a problem hiding this comment.
Right, got lost in all the foldings ;).
KevenRing
force-pushed
the
master
branch
2 times, most recently
from
8e9c67a to
46fd2d1
Compare
… Grabber as a result
|
LGTM |
Added Velodyne VLP Grabber and example viewer
|
Thanks guys! |
|
Awesome, Thanks! |
No description provided.