Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractIndices: keep_organized option for PCLPointCloud2 #1462

Merged

Conversation

wkentaro
Copy link
Contributor

@wkentaro wkentaro commented Dec 3, 2015

No description provided.

@wkentaro wkentaro force-pushed the extract-indices-keep-organized branch from 052e475 to fb6110f Compare December 4, 2015 00:09
@wkentaro
Copy link
Contributor Author

wkentaro commented Dec 4, 2015

test target fails, but this is not where I changed the code.

test 6
        Start   6: a_recognition_cg_test

6: Test command: /home/travis/build/PointCloudLibrary/pcl/build/test/test_recognition_cg "/home/travis/build/PointCloudLibrary/pcl/test/milk.pcd" "/home/travis/build/PointCloudLibrary/pcl/test/milk_cartoon_all_small_clorox.pcd"
6: Test timeout computed to be: 9.99988e+06
6: �[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4020
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4022
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4231
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4727
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4773
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4853
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 4994
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5025
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5065
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5149
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5218
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5296
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5353
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5357
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5430
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5532
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5579
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5582
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5674
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5760
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5839
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5871
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 5879
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6016
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6049
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6064
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6157
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6238
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6259
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6340
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6344
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6345
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6593
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6633
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6636
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6640
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6699
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6731
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6829
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6841
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6887
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6889
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6904
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6965
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 6966
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7092
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7153
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7156
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7219
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7251
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7278
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7286
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7338
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7383
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7384
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7407
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7413
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7466
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7470
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7522
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7529
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7579
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7598
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7628
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7666
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7689
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7692
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7694
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7699
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7710
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7734
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7737
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7744
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7750
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7751
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 7753
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 3769
6: �[0;m�[1;33m[pcl::SHOTEstimation::computeFeature] The local reference frame is not valid! Aborting description of point with index 3770
6: [==========] Running 2 tests from 1 test case.
6: [----------] Global test environment set-up.
6: [----------] 2 tests from PCL
6: [ RUN      ] PCL.Hough3DGrouping
6: /home/travis/build/PointCloudLibrary/pcl/test/test_recognition_cg.cpp:138: Failure
6: Expected: (computeRmsE (model_, scene_, rototranslations[0])) < (1E-4), actual: 0.00235553 vs 0.0001
6: [  FAILED  ] PCL.Hough3DGrouping (260 ms)
6: [ RUN      ] PCL.GeometricConsistencyGrouping
6: [       OK ] PCL.GeometricConsistencyGrouping (252 ms)
6: [----------] 2 tests from PCL (513 ms total)
6: 
6: [----------] Global test environment tear-down
6: [==========] 2 tests from 1 test case ran. (513 ms total)
6: [  PASSED  ] 1 test.
6: [  FAILED  ] 1 test, listed below:
6: [  FAILED  ] PCL.Hough3DGrouping
6: 
6:  1 FAILED TEST
6: �[0;m
  6/102 Test   #6: a_recognition_cg_test ..................***Failed    6.74 sec

@jspricke
Copy link
Member

jspricke commented Dec 4, 2015

Thanks for the pull request, can you implement the if (negative_) case as well?
You are right, the broken unit test has nothing to do with you.

@wkentaro
Copy link
Contributor Author

wkentaro commented Dec 4, 2015

Ok, I added.

jspricke added a commit that referenced this pull request Dec 4, 2015
ExtractIndices: keep_organized option for PCLPointCloud2
@jspricke jspricke merged commit f6ef26a into PointCloudLibrary:master Dec 4, 2015
@wkentaro wkentaro deleted the extract-indices-keep-organized branch December 4, 2015 13:20
wkentaro added a commit to wkentaro/pcl that referenced this pull request Dec 9, 2015
Sorry. This bug is from PointCloudLibrary#1462 by me
and I found the logic is opposite after merged.
SergioRAgostinho pushed a commit to SergioRAgostinho/pcl that referenced this pull request Aug 19, 2016
Sorry. This bug is from PointCloudLibrary#1462 by me
and I found the logic is opposite after merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants