Fixes for MS Visual Studio 2013 #1526
Conversation
…constructor call for pcl::ConditionalRemoval
| @@ -184,7 +184,8 @@ int main (int argc, char *argv[]) | |||
| range_cond->addComparison (pcl::FieldComparison<PointOutT>::ConstPtr (new | |||
| pcl::FieldComparison<PointOutT> ("curvature", pcl::ComparisonOps::GT, threshold))); | |||
| // build the filter | |||
| pcl::ConditionalRemoval<PointOutT> condrem (range_cond); | |||
| pcl::ConditionalRemoval<PointOutT> condrem; | |||
| condrem.setCondition(range_cond); | |||
There was a problem hiding this comment.
Can you please follow the style guide?
There is an extra space at the beginning of these two lines.
There should be a space before the opening parenthesis.
|
Please fix style accordingly to my comment and squash your commits, it will be ok to merge after that! |
|
The misalignment of the first level indentation were inserted since the original file contained tabs in the first level. I replaced now every tab by two spaces each. Hope that this version is now OK. |
|
No 😄 It seems you did no other modifications than indentations in
|
|
Ok, but then I have to adapt my identation level to the wrong style of the file since the file contained tabs as indentation. You wanted me to add two spaces as first identation in the lines I changed (in total two lines). But if I add two spaces and the rest of the file are tabs, this is also not right. Should I place tabs now in order to be consistent to the wrong style of the file or how do you want me to align my changed lines? (All this only belongs example_difference_of_normals.cpp only) |
|
@taketwo Should we fix the code style in a separate commit? |
|
Yes, fix the style in one commit and put your changes in a new one. |
|
Are my changes now correct or is there still something to do from my side? |
|
Can you please squash the commits, to review them? |
|
I've fixed the commits and pushed them into master. Thanks for the fixes! |
Dear PCL development team,
this pull request contains three fixes for a proper compilation under MS Visual Studio 2013 if the surface_nurbs project is enabled. It would be great if you could merge this.
Thanks.
Marc