PLYReader: thread safe colors

[mikhail-matrosov]

Bug fix: PLYReader would give corrupted colors if used in a parallel
code.

[SergioRAgostinho]

Thanks. Could you please follow
http://pointclouds.org/documentation/advanced/pcl_style_guide.php#member-variables
http://pointclouds.org/documentation/advanced/pcl_style_guide.php#indentation-and-formatting

Also, add a comment explaining what those members are and initialize them properly in the class constructors.

[mikhail-matrosov]

Renamed and initialized variables in comply with pcl guidelines, corrected indentation. Sorry for the previous commit =)

[SergioRAgostinho]

Final comment. Could you please squash the commits into a single one.

[mikhail-matrosov]

Done

[VictorLamoine]

👍

[SergioRAgostinho]

👍 thanks

[SergioRAgostinho]

Sorry to be picky once again, can you amend the commit message. You concatenated the message from the three commits you squashed.

[mikhail-matrosov]

No problem

[SergioRAgostinho]

This PR broke the pcl_io 1.8.0 ABI. We can always revert it temporarily before the release.

[taketwo]

I'd say let's have a release candidate branch and revert it there?

[SergioRAgostinho]

But then can we properly tag the main branch?

[jspricke]

+1 for revert in release branch. (at tag is not associated with a branch ;) ).

[taketwo]

Yes, we work with a release branch, eventually tag it's tip, and then wipe the branch.