Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Ubuntu arm64 platform #1715

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

LocutusOfBorg
Copy link
Contributor

This fixes the build when GL* structs are undefined.

This fixes the build when GL* structs are undefined.
@SergioRAgostinho
Copy link
Member

I have no way of checking this. Although the change seems harmless I wonder if it's the most correct one. I just it find strange that one needs to manually do it, and that Qt doesn't somehow include those for you. What error were you having from the compiler exactly?

@jspricke jspricke merged commit a87ef3c into PointCloudLibrary:master Sep 23, 2016
@LocutusOfBorg LocutusOfBorg deleted the patch-1 branch September 27, 2016 13:03
@LocutusOfBorg
Copy link
Contributor Author

Hi @jspricke @SergioRAgostinho

I have no way of checking this.

in a Debian/Ubuntu is trivial

pbuilder-dist yakkety arm64 create
pbuilder-dist yakkety arm64 login

(you need ubuntu-dev-tools and qemu-user-static IIRC)

Although the change seems harmless I wonder if it's the most correct one. I just it find strange that >one needs to manually do it, and that Qt doesn't somehow include those for you.

I find strange that it fails only arm64, but probably this is because arm64 has different GL implementation

What error were you having from the compiler exactly?

https://launchpad.net/ubuntu/+source/pcl/1.8.0+dfsg1-3ubuntu1

BTW, you are already doing that in your source code, according to
grep OPENGL_IS_A_FRAMEWORK . -R

You use GL structs, you need to include GL for this. Probably some QT implementations has the side effect of including it indirectly, but this isn't a reason to not include it, because the qt implementation can change or not have GL compatibility.
(not sure if the program works on arm64, BTW)

@jspricke
Copy link
Member

Hi @LocutusOfBorg

thanks for the explanations and the patch, I've merged it already (although I wasn't able to reproduce it).

@jspricke
Copy link
Member

..on Debian, I mean

@LocutusOfBorg
Copy link
Contributor Author

yes, I saw the merge thanks!
I don't know, maybe some qt folks can answer this question, but I really think the arm64 support is broken in qt somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants