Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Octree unit tests #1906

Merged

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Jun 27, 2017

(follow-up for #1532)

  • Use appropriate GTest assertions
  • Enforce PCL style
  • Delete trailing spaces

* Use appropriate GTest assertions
* Enforce PCL style
* Delete trailing spaces
@SergioRAgostinho
Copy link
Member

Thanks. 👍

Just for reference, from https://github.com/google/googletest/blob/master/googletest/docs/Primer.md

Historical note: Before February 2016 *_EQ had a convention of calling it as ASSERT_EQ(expected, actual), so lots of existing code uses this order. Now *_EQ treats both parameters in the same way.

Although I'm still in favour of retaining the same order convention for a while.

@SergioRAgostinho SergioRAgostinho added this to the pcl-1.8.1 milestone Jun 27, 2017
@taketwo
Copy link
Member Author

taketwo commented Jun 27, 2017

Thanks, did not know this. But yeah, my GTest on Ubuntu 16.04 still prints in case of failure something like:

/home/sergey/Workspace/Libraries/pcl/test/octree/test_octree.cpp:1669: Failure
Value of: leaf_container->size ()
  Actual: 18
Expected: 27

so better have it in the conventional right order for the time being.

@SergioRAgostinho SergioRAgostinho merged commit b6b5463 into PointCloudLibrary:master Jun 27, 2017
@taketwo taketwo deleted the update-assertions branch June 27, 2017 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants