Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for macro _USE_MATH_DEFINES. #1956

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Add test for macro _USE_MATH_DEFINES. #1956

merged 1 commit into from
Aug 7, 2017

Conversation

ShiningPluto
Copy link
Contributor

Eliminating the warning message of repeated definition of macro when you defined it yourself.

@SergioRAgostinho
Copy link
Member

This should be perfectly ok for 1.8.1. Any arguments against it?

taketwo
taketwo approved these changes Aug 7, 2017
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything against.

@taketwo taketwo merged commit 8664459 into PointCloudLibrary:master Aug 7, 2017
@SergioRAgostinho SergioRAgostinho mentioned this pull request Aug 6, 2018
Closed
@SergioRAgostinho SergioRAgostinho mentioned this pull request Aug 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShiningPluto @SergioRAgostinho @taketwo