Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of PCA deprecated constructor #2070

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Removal of PCA deprecated constructor #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions common/include/pcl/common/impl/pca.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,6 @@
#include <pcl/common/transforms.h>
#include <pcl/exceptions.h>

/////////////////////////////////////////////////////////////////////////////////////////
/** \brief Constructor with direct computation
* \param[in] cloud input m*n matrix (ie n vectors of R(m))
* \param[in] basis_only flag to compute only the PCA basis
*/
template<typename PointT>
pcl::PCA<PointT>::PCA (const pcl::PointCloud<PointT> &cloud, bool basis_only)
{
Base ();
basis_only_ = basis_only;
setInputCloud (cloud.makeShared ());
compute_done_ = initCompute ();
}

/////////////////////////////////////////////////////////////////////////////////////////
template<typename PointT> bool
pcl::PCA<PointT>::initCompute ()
Expand Down
7 changes: 0 additions & 7 deletions common/include/pcl/common/pca.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,6 @@ namespace pcl
, mean_ ()
, eigenvalues_ ()
{}

/** \brief Constructor with direct computation
* X input m*n matrix (ie n vectors of R(m))
* basis_only flag to compute only the PCA basis
*/
PCL_DEPRECATED ("Use PCA (bool basis_only); setInputCloud (X.makeShared ()); instead")
PCA (const pcl::PointCloud<PointT>& X, bool basis_only = false);

/** Copy Constructor
* \param[in] pca PCA object
Expand Down