Removed computeWeirdPointNormals from normal_3d.cu #2208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function "computeWeirdPointNormals" and its associated template instantiations are undocumented, unused anywhere in PCL, and cause compilation failure with CUDA 9.1 on Ubuntu (see issue #2207). This fix results in successful compilation.
|
Under these circumstances (no documentation, unused, broken), I'd say it's fine to wipe this function out indeed. @SergioRAgostinho what do you think? Alternatively, we can be conservative and just conditionally disable it for CUDA >= 9. |
|
I need to spend some time on it to have a better insight. I'll provide feedback before the 1.9 release. |
SergioRAgostinho
removed
the
needs: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function "computeWeirdPointNormals" and its associated template instantiations are undocumented, unused anywhere in PCL, and cause compilation failure with CUDA 9.1 on Ubuntu (see issue #2207). This fix results in successful compilation.