Use GLuint rather than size_t to represent OpenGL indices. #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size_t size in byte is dependent on the machine architecture. In contrast, the OpenGL indices must be 32bits. Specifically size_t does not work on any 64bits machine.
taketwo
approved these changes
Mar 1, 2018
SergioRAgostinho
added
module: simulation
changelog: API break
|
I'm baffled by the existence of a container of indices at global scope. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the simulation model rendering, use GLuint rather than size_t to represent OpenGL indices.
size_t size in byte is dependent on the machine architecture.
In contrast, the OpenGL indices must be 32bits.
Specifically size_t being 64bits on a 64bits machine, it will be the wrong size for OpenGL .