Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependecy to apps #2251

Conversation

frozar
Copy link
Contributor

@frozar frozar commented Mar 12, 2018

Add the 2d library as a dependance in application directory.

I really would like to see the different existing application of PCL but most of them are obsolete/doesn't compile, etc...

I tried to compile pcl_apps_point_cloud_editor with the following command:

cmake -DBUILD_apps=ON -DBUILD_apps_point_cloud_editor=ON && make

Unfortunately, the file apps/CMakeFiles/pcl_pcd_organized_edge_detection.dir/src/pcd_organized_edge_detection.cpp.o didn't compile because of missing include directory 2d/include.

This PR fixes it.

@SergioRAgostinho SergioRAgostinho added the needs: code review Specify why not closed/merged yet label Mar 12, 2018
@SergioRAgostinho SergioRAgostinho merged commit fc88d45 into PointCloudLibrary:master Mar 12, 2018
@SergioRAgostinho
Copy link
Member

👍 thanks.

@SergioRAgostinho SergioRAgostinho removed the needs: code review Specify why not closed/merged yet label Mar 12, 2018
@frozar frozar deleted the fix_compil_pcd_organized_edge_detection branch March 13, 2018 09:18
@SergioRAgostinho SergioRAgostinho changed the title [CMAKE] Fix apps compilation Add missing dependecy to apps Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants