Warn and skip adding normal cloud if it is empty #2265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
PCLVisualizer::addPointCloudNormals()
function does not check if the supplied normal cloud is empty. While perhaps logically it's okay to add an empty cloud, the implementation of the function can not deal with empty clouds (see this line,size_t
underflows andnr_normals
becomes a ridiculously large number, bad alloc follows). This patch adds an a warning and an early return to avoid issues.