Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified GlasbeyLUT indexing type to size_t #2297

Merged
merged 2 commits into from
May 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/include/pcl/common/colors.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ namespace pcl
/** Get a color from the lookup table with a given id.
*
* The id should be less than the size of the LUT (see size()). */
static RGB at (unsigned int color_id);
static RGB at (size_t color_id);

/** Get the number of colors in the lookup table.
*
Expand Down
4 changes: 2 additions & 2 deletions common/src/colors.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ static const unsigned char GLASBEY_LUT[] =
};

/// Number of colors in Glasbey lookup table
static const unsigned int GLASBEY_LUT_SIZE = sizeof (GLASBEY_LUT) / (sizeof (GLASBEY_LUT[0]) * 3);
static const size_t GLASBEY_LUT_SIZE = sizeof (GLASBEY_LUT) / (sizeof (GLASBEY_LUT[0]) * 3);

pcl::RGB
pcl::GlasbeyLUT::at (unsigned int color_id)
pcl::GlasbeyLUT::at (size_t color_id)
{
assert (color_id < GLASBEY_LUT_SIZE);
pcl::RGB color;
Expand Down
2 changes: 1 addition & 1 deletion visualization/src/pcl_visualizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3858,7 +3858,7 @@ pcl::visualization::PCLVisualizer::renderViewTesselatedSphere (
cam->SetViewAngle (view_angle);
cam->Modified ();

//For each camera position, traposesnsform the object and render view
//For each camera position, transform the object and render view
for (size_t i = 0; i < cam_positions.size (); i++)
{
cam_pos[0] = cam_positions[i][0];
Expand Down