Explictly use mt19937 random generator for boost 1.67. #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-vri-es
force-pushed
the
outofcore-boost167-random-generator
branch
from
227a161 to
2309bda
Compare
|
Hmm, the test failure seems unrelated? |
|
Yeah, must be something else. I think just using the old behavior explicitly is good enough for now. We can always add |
|
Thanks for the quick review! :) |
Closed
SergioRAgostinho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2284.
Boost 1.67 switched the default
boost::uuid::random_generatorfromboost::uuid::basic_random_generator<boost::mt19937>toboost::uuid::random_generator_purewhich uses OS provided randomness.The new one doesn't accept a PRNG as constructor argument anymore. This PR switches back to the old behaviour explicitly.
It may actually be a good idea to switch to the new behaviour, but that would require some preprocessor checks to stay compatible with boost < 1.67. This PR doesn't change anything, it just chooses the old default explicitly.
Preprocessor checks can be added instead if that has the preference.