Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase threshold for expected value in test_non_linear #2424

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Sep 9, 2018

Fixes #2288.

@SergioRAgostinho
Copy link
Member

Quick debate: I'm questioning removing that check entirely? It's not useful.

@taketwo
Copy link
Member Author

taketwo commented Sep 9, 2018

I think we need to verify that the call to segment() returns at least some inliers.

@taketwo
Copy link
Member Author

taketwo commented Sep 9, 2018

Though we may relax the threshold even more to avoid problems in future.

@SergioRAgostinho
Copy link
Member

SergioRAgostinho commented Sep 9, 2018

I assumed so and its a valid approach. Alternatively I was thinking if setting a fixed random seed before would also prevent problems.

@taketwo
Copy link
Member Author

taketwo commented Sep 9, 2018

Fixing the seed is a good approach, but I don't think it's possible here. SampleConsensus class has a private member variable rng_ containing the random generator and we don't have access to it to set the seed.

@SergioRAgostinho SergioRAgostinho merged commit d3d3d29 into PointCloudLibrary:master Sep 10, 2018
@taketwo taketwo deleted the fix-2288 branch September 10, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants