Do not mark imported libraries as GLOBAL in PCLConfig #2435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2431.
Following up the discussion in #2431 I demoted exported targets to be local. The component "has been found already" test is reverted back to check
PCL_xxx_FOUND
variable. As a result:A little more explanation for the last point. Suppose the root CMakeLists finds only few PCL components:
find_package(PCL REQUIRED COMPONENTS common features)
After that it's okay if in a subdirectory another search is performed with more components:
find_package(PCL REQUIRED COMPONENTS common visualization tracking)
@jasjuang Please give this an extensive testing :)